Commitddc1bae

authored

feat(runtime-vapor): support render block in createDynamicComponent (#14213)

1 parent624fa7e commitddc1baeCopy full SHA for ddc1bae

File tree

+23

-9

lines changed

+23

-9

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,4 +179,15 @@ describe('api: createDynamicComponent', () => {`
`179`	`179`	`'<div><span>hi</span><!--slot--></div><!--dynamic-component-->',`
`180`	`180`	`)`
`181`	`181`	`})`
	`182`	`+`
	`183`	`+test('accept blocks',async()=>{`
	`184`	`+const{ html}=define({`
	`185`	`+setup(){`
	`186`	`+constn0=template('<a>router link</a>')()`
	`187`	`+returncreateDynamicComponent(()=>n0)`
	`188`	`+},`
	`189`	`+}).render()`
	`190`	`+`
	`191`	`+expect(html()).toBe('<a>router link</a><!--dynamic-component-->')`
	`192`	`+})`
`182`	`193`	`})`

Lines changed: 12 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import{currentInstance,resolveDynamicComponent}from'@vue/runtime-dom'`
`2`		`-import{insert}from'./block'`
	`2`	`+import{insert,isBlock}from'./block'`
`3`	`3`	`import{createComponentWithFallback,emptyContext}from'./component'`
`4`	`4`	`import{renderEffect}from'./renderEffect'`
`5`	`5`	`importtype{RawProps}from'./componentProps'`
`@@ -36,14 +36,17 @@ export function createDynamicComponent(`
`36`	`36`	`(currentInstance&&currentInstance.appContext)\|\|emptyContext`
`37`	`37`	`frag.update(`
`38`	`38`	`()=>`
`39`		`-createComponentWithFallback(`
`40`		`-resolveDynamicComponent(value)asany,`
`41`		`-rawProps,`
`42`		`-rawSlots,`
`43`		`-isSingleRoot,`
`44`		`-once,`
`45`		`-appContext,`
`46`		`-),`
	`39`	`+// Support integration with VaporRouterView/VaporRouterLink by accepting blocks`
	`40`	`+isBlock(value)`
	`41`	`+ ?value`
	`42`	`+ :createComponentWithFallback(`
	`43`	`+resolveDynamicComponent(value)asany,`
	`44`	`+rawProps,`
	`45`	`+rawSlots,`
	`46`	`+isSingleRoot,`
	`47`	`+once,`
	`48`	`+appContext,`
	`49`	`+),`
`47`	`50`	`value,`
`48`	`51`	`)`
`49`	`52`	`}`

Comments

(0)