Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Setname attribute of radio-groups which are scoped to the instance#696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cravindra wants to merge4 commits intovue-generators:master
base:master
Choose a base branch
Loading
fromcravindra:scoped-radio-groups

Conversation

cravindra
Copy link

Decouples the name attribute from the model value and makes it unique
across multiple instances of radio fields which may now share the same
model value and still operate independently

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix
  • What is the new behavior (if this is a feature change)?
    Radio fields now generate a unique name which is shared within an instance and unique across different instances
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:

Decouples the name attribute from the model value and makes it uniqueacross multiple instances of radio fields which may now share the samemodel value and still operate independently
@coveralls
Copy link

coveralls commentedDec 8, 2020
edited
Loading

Coverage Status

Coverage remained the same at 89.979% when pullingee5abf3 on cravindra:scoped-radio-groups into721a4ee on vue-generators:master.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@cravindra@coveralls

[8]ページ先頭

©2009-2025 Movatter.jp