Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add a parameter to define if we manage nfs server service ensure state#183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ttousai wants to merge3 commits intovoxpupuli:master
base:master
Choose a base branch
Loading
fromttousai:add-parm

Conversation

@ttousai
Copy link

We want puppet-nfs to manage the NFS service but not manage the service state (running/stopped) because that state is managed by another tool.

@TheMeier
Copy link
Contributor

That sounds like an anti pattern to me. No 2 tools should manage the same resource

@tuxmea
Copy link
Member

Usually I would agree with the comment#183 (comment)

But other modules are doing the same: class parameter to set the ensure or enable state.

@ttousai can you please rebase your branch?

@h-haaks
Copy link

h-haaks commentedJun 10, 2024
edited
Loading

I tend to agree with@TheMeier on this one.
We usually have params to manage the service or not, and if we do manage it we have params to ensure stopped/running and enabled/disabled ( at boot )

If there is another tool involved managing the service state that tool should manage the enabled/disabled state as well.

@tuxmea
Copy link
Member

There are reasons why puppet should not start the service. e.g. nfs ist started by pacemaker/corosync.
From my point of view the request to have a parameter makes sense.
Maybe the description was a little bit misleading.

@h-haaks
Copy link

To me the example you mention is exactly the kind of edge case where I would setmanage_server_service to false and manage the service in aprofile class.

TheMeier reacted with thumbs up emoji

@saz
Copy link
Member

saz commentedJan 10, 2025

For e.g. pacemaker setups, everything should be managed by Puppet, except the state of the service, as this should be handled by pacemaker.

There's already a parameter availableserver_service_ensure.
Shouldn't it be enough to allowundef to be set here?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ttousai@TheMeier@tuxmea@h-haaks@saz

[8]ページ先頭

©2009-2025 Movatter.jp