Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Flush buffers before reading back in to construct all seen addresses#206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
timpalpant wants to merge1 commit intovmprof:master
base:master
Choose a base branch
Loading
fromtimpalpant:flush-buffers

Conversation

timpalpant
Copy link
Contributor

When disabling profiling, the log of samples written is read back in byLogReaderDumpNative to construct a deduplicated set of all code addresses that were recorded during sampling. This set is then passed to_vmprof.write_all_code_objects to write out the address and file/symbol info.

However if the last call tocommit_buffer is a short write (for example because it was interrupted by a signal), then the LogReader may not be able to parse the tail of the file because we may still have pending un-flushed buffers (see:_write_single_ready_buffer).

This change adds a function to ensure all pending buffers are flushed to disk before attempting to reread them with the LogReader.

@mattip
Copy link
Contributor

Could you add a test that hits the new code?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@timpalpant@mattip@palpant-dbx

[8]ページ先頭

©2009-2025 Movatter.jp