Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5be1ef5

Browse files
author
minjk-bl
committed
Edit popup component to focus on empty required field
1 parent6dbf090 commit5be1ef5

File tree

23 files changed

+123
-48
lines changed

23 files changed

+123
-48
lines changed

‎data/m_library/pandasLibrary.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5023,7 +5023,8 @@ define([
50235023
name:'i0',
50245024
type:'var',
50255025
label:'DataFrame',
5026-
var_type:['DataFrame','Series']
5026+
var_type:['DataFrame','Series'],
5027+
required:true
50275028
}
50285029
],
50295030
output:[

‎html/m_apps/bind.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<divclass="vp-bd-type-box concat">
1212
<div>
1313
<labelfor="vp_bdVariable"class="vp-orange-text w100">DataFrame</label>
14-
<inputtype="text"id="vp_bdVariable"placeholder="Select variables"readonly="">
14+
<inputtype="text"id="vp_bdVariable"placeholder="Select variables"readonly=""required="true"t>
1515
</div>
1616
<div>
1717
<labelfor="vp_bdJoin"class="w100">Join</label>

‎html/m_apps/groupby.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</div>
1010
<div>
1111
<labelfor="vp_gbBy"class="vp-orange-text w80">Groupby</label>
12-
<inputtype="text"id="vp_gbBy"placeholder="Groupby columns"readonly="">
12+
<inputtype="text"id="vp_gbBy"placeholder="Groupby columns"readonly=""required="true">
1313
<label><inputtype="checkbox"id="vp_gbByGrouper"disabled=""><span>Grouper</span></label>
1414
<divclass="vp-gb-by-grouper-box"style="display:none;">
1515
<inputtype="number"id="vp_gbByGrouperNumber"class="vp-gb-by-number">

‎html/m_apps/pdf.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<divclass="vp-pdf-df-box">
1313
<labelfor="vp_pdfVariable"class="vp-orange-text">File Path</label>
1414
<div>
15-
<inputtype="text"id="vp_pdfFile"class="vp-state vp-input input-single vp-pdf-filepath"index="0"placeholder=""value=""title=""><divid="vp_openFileNavigationBtn"class="vp-file-browser-button"></div>
15+
<inputtype="text"id="vp_pdfFile"class="vp-state vp-input input-single vp-pdf-filepath"index="0"placeholder=""value=""title=""required="true"><divid="vp_openFileNavigationBtn"class="vp-file-browser-button"></div>
1616
</div>
1717
<labelfor="vp_pdfReturn">Allocate to</label>
1818
<div>

‎html/m_apps/profiling.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<divclass="vp-pf-df-refresh"title="Refresh variable list"><imgsrc="/nbextensions/visualpython/img/refresh.svg"></div>
1919
</div>
2020
<labelfor="vp_pfReturn"class="vp-orange-text">Allocate to</label>
21-
<inputtype="text"id="vp_pfReturn"class="vp-input vp-pf-input"placeholder="New variable name">
21+
<inputtype="text"id="vp_pfReturn"class="vp-input vp-pf-input"placeholder="New variable name"required="true">
2222
<labelfor="vp_pfTitle">Report Title</label>
2323
<div>
2424
<inputtype="text"id="vp_pfTitle"class="vp-input vp-pf-input"placeholder="Title name">

‎html/m_apps/reshape.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</div>
2323
<div>
2424
<labelfor="vp_rsColumns"class="vp-orange-text w100">Columns</label>
25-
<inputtype="text"id="vp_rsColumns"placeholder="Columns key"readonly="">
25+
<inputtype="text"id="vp_rsColumns"placeholder="Columns key"readonly=""required="true">
2626
</div>
2727
<div>
2828
<labelfor="vp_rsValues"class="w100">Values</label>

‎html/m_visualize/chart.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
<tr>
107107
<thclass="vp-orange-text">Y Value</th>
108108
<td>
109-
<inputtype="text"class="vp-input vp-state"id="y"/>
109+
<inputtype="text"class="vp-input vp-state"id="y"required="true"/>
110110
</td>
111111
</tr>
112112
<tr>

‎html/m_visualize/wordCloud.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
</div>
1313
<divclass="vp-tab-page-box vp-grid-border-box vp-scrollbar">
1414
<divclass="vp-tab-page vp-grid-box"data-type="data">
15-
<labelfor="data"class="vp-bold">Data</label>
15+
<labelfor="data"class="vp-bold vp-orange-text">Data</label>
1616
<div>
17-
<inputtype="text"id="data"class="vp-input vp-state"/>
17+
<inputtype="text"id="data"class="vp-input vp-state"required="true"/>
1818
<label><inputtype="checkbox"id="useFile"class="vp-state"><span>Use file</span></label>
1919
<divid="vp_wcOpenFile"class="vp-file-browser-button"style="display:none;"></div>
2020
</div>

‎js/com/com_generator.js‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,9 @@ define([
189189
}else{
190190
suggestInput.setPlaceholder('Type or Select value');
191191
}
192+
if(required===true){
193+
suggestInput.addAttribute('required',true);
194+
}
192195
suggestInput.setSelectEvent(function(selectedValue){
193196
// trigger change
194197
$(pageThis.wrapSelector('#'+obj.name)).val(selectedValue);
@@ -202,9 +205,10 @@ define([
202205
$(tag).attr({
203206
'type':'text',
204207
'id':obj.name,
205-
'class':'vp-input vp-state'
208+
'class':'vp-input vp-state',
209+
'required':required===true
206210
});
207-
vp_generateVarSuggestInput(divTag,obj);
211+
vp_generateVarSuggestInput(divTag,obj,required);
208212
tblInput.appendChild(tag);
209213
break;
210214
case'var_multi':
@@ -244,7 +248,8 @@ define([
244248
'id':obj.name,
245249
'placeholder':(obj.placeholder==undefined?'':obj.placeholder),
246250
'value':(obj.default==undefined?'':obj.default),
247-
'title':(obj.help==undefined?'':obj.help)
251+
'title':(obj.help==undefined?'':obj.help),
252+
'required':required===true
248253
});
249254
// cell metadata test
250255
if(getValue&&obj.value!=undefined){
@@ -268,7 +273,8 @@ define([
268273
'id':obj.name,
269274
'placeholder':(obj.placeholder==undefined?'':obj.placeholder),
270275
'value':(obj.default==undefined?'':obj.default),
271-
'title':(obj.help==undefined?'':obj.help)
276+
'title':(obj.help==undefined?'':obj.help),
277+
'required':required===true
272278
});
273279
// cell metadata test
274280
if(getValue&&obj.value!=undefined){
@@ -289,7 +295,7 @@ define([
289295
* Generate suggest input
290296
*@param {object} obj
291297
*/
292-
varvp_generateVarSuggestInput=function(divTag,obj){
298+
varvp_generateVarSuggestInput=function(divTag,obj,required=false){
293299
vartypes=obj.var_type;
294300
vardefaultValue=obj.value;
295301

@@ -320,6 +326,9 @@ define([
320326
if(obj.placeholder!=undefined){
321327
suggestInput.setPlaceholder(obj.placeholder);
322328
}
329+
if(required===true){
330+
suggestInput.addAttribute('required',true);
331+
}
323332
suggestInput.setSelectEvent(function(selectedValue){
324333
// trigger change
325334
$(divTag+' #'+obj.name).val(selectedValue);

‎js/com/com_generatorV2.js‎

Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,9 @@ define([
341341
if(obj.placeholder!=undefined){
342342
suggestInput.setPlaceholder(obj.placeholder);
343343
}
344+
if(obj.required===true){
345+
suggestInput.addAttribute('required',true);
346+
}
344347
suggestInput.setSelectEvent(function(selectedValue){
345348
// trigger change
346349
$(pageThis.wrapSelector('#'+obj.name)).val(selectedValue);
@@ -354,16 +357,18 @@ define([
354357
id:obj.name,
355358
allowDataType:obj.var_type,
356359
placeholder:obj.placeholder||'Select data',
357-
value:value
360+
value:value,
361+
required:obj.required===true
358362
});
359363
content=$(dataSelector.toTagString());
360364
break;
361365
case'var_select':
362366
// suggest input tag
363367
vartag=$('<input/>').attr({
364-
'type':'text',
365-
'id':obj.name,
366-
'class':'vp-input vp-state'
368+
type:'text',
369+
id:obj.name,
370+
class:'vp-input vp-state',
371+
required:obj.required===true
367372
});
368373
vp_generateVarSuggestInput(pageThis.wrapSelector(),obj);
369374
content=tag;
@@ -398,12 +403,13 @@ define([
398403
break;
399404
case'input_number':
400405
varinput=$('<input/>').attr({
401-
'type':'number',
402-
'class':'vp-input vp-state',
403-
'id':obj.name,
404-
'placeholder':(obj.placeholder==undefined?'Input Number':obj.placeholder),
405-
'value':(obj.default==undefined?'':obj.default),
406-
'title':(obj.help==undefined?'':obj.help)
406+
type:'number',
407+
class:'vp-input vp-state',
408+
id:obj.name,
409+
placeholder:(obj.placeholder==undefined?'Input Number':obj.placeholder),
410+
value:(obj.default==undefined?'':obj.default),
411+
title:(obj.help==undefined?'':obj.help),
412+
required:obj.required===true
407413
});
408414
if(obj.step!=undefined){
409415
$(input).attr({'step':obj.step});
@@ -430,12 +436,13 @@ define([
430436
// default : input_single
431437
default:
432438
varinput=$('<input/>').attr({
433-
'type':'text',
434-
'class':'vp-input input-single vp-state',
435-
'id':obj.name,
436-
'placeholder':(obj.placeholder==undefined?'Input Data':obj.placeholder),
437-
'value':(obj.default==undefined?'':obj.default),
438-
'title':(obj.help==undefined?'':obj.help)
439+
type:'text',
440+
class:'vp-input input-single vp-state',
441+
id:obj.name,
442+
placeholder:(obj.placeholder==undefined?'Input Data':obj.placeholder),
443+
value:(obj.default==undefined?'':obj.default),
444+
title:(obj.help==undefined?'':obj.help),
445+
required:obj.required==true
439446
});
440447
// cell metadata test
441448
if(value!=undefined){
@@ -490,6 +497,9 @@ define([
490497
suggestInput.setSuggestList(function(){returnvarList;});
491498
suggestInput.setNormalFilter(false);
492499
suggestInput.setValue(defaultValue);
500+
if(obj.required===true){
501+
suggestInput.addAttribute('required',true);
502+
}
493503
if(obj.placeholder!=undefined){
494504
suggestInput.setPlaceholder(obj.placeholder);
495505
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp