ping@litoj@jamespeapen

I think a couple small changes should be done:

• the id is not a keyword, so we shouldn't be highlighting it as one
• we already have a match for bar block without the id, therefore the id in this group should be required
• since the id is basically any kind of text value we should account for that

My suggestion:

synregionswayConfigBarBlockAfterIdstart=/{$/end=/^\s*}\zs$/containedcontains=i3ConfigBarOpts,i3ConfigComment,i3ConfigParen,i3ConfigBindKeyword,i3ConfigColorsBlockfoldkeependextendsynmatchswayConfigBarId/[^{]*/containedcontains=@i3ConfigStrVarsynregioni3ConfigBarBlockmatchgroup=i3ConfigKeywordstart=/bar\ze [^{]/end=/\ze{$/containedcontains=swayConfigBarIdnextgroup=swayConfigBarBlockAfterId...hideflinkswayConfigBarIdi3ConfigString

It is a little more convoluted but it ensures only the id is allowed to be a string or a variable and not the contents of the block while highlighting the ID as a string by default.

Those are good points, thanks!

Actually, what we need here is kind of similar to other regions likeinput,output, orseat. The only difference is that the identifier is optional. I definedswayConfigBar andswayConfigBarIdent, andbar can now be followed by either one of them.

We could do it that way, but that requires other changes as well:

• currently, thefonts keyword usescontainedin to inject itself into the bar block, which doesn't work when we create a group with a different name
• the identifier can also be a string so we shouldn't be matching by non-space but rather non-{
• we'd have to removei3ConfigBarBlock from@i3ConfigTopLevelDirective and replace it withswayConfigBarBlock

Note: my previous solution doesn't work with the fonts either, so we have to change them to a separate highlight group anyway (and add them to top-level directive)

Since the way identifiers were highlighted was a little confusing overall I decided to apply the approach here from@kupospelov to all i3/sway identifier matchers across both syntax files. I updated it in the plugin repo -litoj/i3config.vim@e665b92

@kupospelov Could you please mirror it into your PR to merge those changes?