Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/vimPublic

runtime(groff)!: update groff compiler#17182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
e-kwsm wants to merge1 commit intovim:master
base:master
Choose a base branch
Loading
frome-kwsm:groff-compiler

Conversation

e-kwsm
Copy link
Contributor

Problem: groff compiler assumes a single argument, i.e. output device like html, but the requirement is not checked properly. Also, macro packages is hardcoded to mom.
Solution: Control output device and macro package by variable. Arguments for :make are now ignored.

#17181

Problem: groff compiler assumes a single argument, i.e. output device         like html, but the requirement is not checked properly.  Also,         macro packages is hardcoded to mom.Solution: Control output device and macro package by variable.          Arguments for :make are now ignored.vim#17181Signed-off-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
@Konfekt
Copy link
Contributor

Currenty-mom -T$* -- %:S > %:r:S.$* letsmake pdf ormake html output to a PDF or HTML file (similar to the pandoc compiler). This is more convenient than changingget(b:, 'groff_output_dev', get(g:, 'groff_output_dev', 'utf8')). This entails passing other arguments than the single output format byb/g:groff_ variables, but that's a restriction of:make itself. A workaround could be an additional command:Make/Groff to parse- arguments.

@chrisbra
Copy link
Member

Is that an ACK@Konfekt ?

@Konfekt
Copy link
Contributor

Not quite. I found, say,make pdf ormake html in a MOM file as natural as flexible to create an output of that format. Now it outputs anutf8 file by default and no longer allows switching output format, other than by changingg/b:groff_output_dev. That's impractical

@chrisbra
Copy link
Member

alright, makes sense. So let's make this draft so long.

@chrisbrachrisbra marked this pull request as draftApril 22, 2025 18:41
@e-kwsm
Copy link
ContributorAuthor

It would be helpful if something likeE119: Not enough arguments andE118: Too many arguments are issued for:make and:make pdf html, respectively.

And I feel raw PDF data in quickfix is noisy..

Screenshot From 2025-04-24 10-47-22

@Konfekt
Copy link
Contributor

Konfekt commentedApr 24, 2025
edited
Loading

And I feel raw PDF data in quickfix is noisy

That's true. But when I try:make pdf on a Mom file, output reads
grafik

Can errorformat's%+/-G help here?

@Konfekt
Copy link
Contributor

Konfekt commentedApr 24, 2025
edited
Loading

E119: Not enough arguments and E118: Too many arguments

I think:make inherently comes to an end of its capabilities and in principle needs to be expanded in Vim itself, say for the moment in anofficial async:Make.

For this issue, I guess one would have to add a buffer-local:Groff or:Make (taken by many plug-ins, see above) command to handle these arguments gracefully? (Then maybe similarly for pandoc, to make it somewhat coherent).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-kwsm@Konfekt@chrisbra

[8]ページ先頭

©2009-2025 Movatter.jp