Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add constructor with ToastType only#993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
NathanJPhillips wants to merge1 commit intovikramlearning:main
base:main
Choose a base branch
Loading
fromNathanJPhillips:ToastMessage-constructor

Conversation

@NathanJPhillips
Copy link
Contributor

Add a constructor forToastMessage that takesToastType only.

With the newRenderFragment toast content a constructor that takesToastType but not a string message now makes sense.

At the same time make some changes to other constructors:
o Invoke simpler constructors from more complex ones to avoid duplicating code
o Use default argument forautoHide instead of writing two separate constructors
o AddautoHide parameter to constructor that takesIconName to mirror the constructor that takescustomIconName

@NathanJPhillips
Copy link
ContributorAuthor

Check failure looks unrelated to my changes. I believe it's caused by this error:
The format of the analysis property sonar.login= is invalid

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NathanJPhillips

[8]ページ先頭

©2009-2025 Movatter.jp