- Notifications
You must be signed in to change notification settings - Fork2.7k
Improve playlist alignment when PDT across playlists is inconsistent#7482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
hongjun-bae left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I understand that this modification was made because simply increasing the tolerance cannot fundamentally resolve cases where the PDT alignment is completely incorrect.
| constdelta=(targetPDT-refPDT)/1000-(frag.start-refFrag.start); | ||
| constdateDifference=(targetPDT-refPDT)/1000; | ||
| if(Math.abs(dateDifference)>Math.max(60,details.totalduration)){ |
hongjun-baeNov 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The issue of small timing gaps, such as 352ms, was raised in#7557, but what was the reason for setting the PDT to 60 seconds? Is there a specific reason why “totalduration” was set as the default value? I’m worried that I’m not allowing for enough discontinuities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And if the alignment fails like this, logging will be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The issue of small timing gaps, such as 352ms, was raised in#7557,
How so?#7557 will be resolved by#7626.
Small gaps will not have a major impact on segment selection. Ultimately, playlists are realigned once video and audio timestamps are known. VTT mapping is not used in alignment. This change only aims to skip alignment using Program-Date-Time when the date times are wildly inconsistent between playlists - more thantotalduration would mean there is no overlap, but for very short playlists, we'll enforce a minimum of 60 seconds.
And if the alignment fails like this, logging will be necessary.
Logging can be added before merging.
This PR will...
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist