- Notifications
You must be signed in to change notification settings - Fork556
feat(web-validation): replace deprecated SchemaParser with new Schema…#2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:4.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tsegismont left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@pk-work
Have you been able to get to the bottom of the failures?
vertx-web-validation/src/main/java/io/vertx/ext/web/validation/ValidationHandler.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
vertx-web-validation/src/main/java/io/vertx/ext/web/validation/ValidationHandler.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...b-validation/src/main/java/io/vertx/ext/web/validation/builder/ValidationHandlerBuilder.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| // Not the best way to retrieve Vert. instance I guess. We could also try to get it from SchemaRouter | ||
| // via schemaParser.getSchemaRouter(), but the vertx field is private. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That is an acceptable limitation, I think. Anyway it's only temporary.
When this is merged, keep in mind to document the limitation in the deprecations and breaking changes doc.
…RepositorySigned-off-by: Pascal Krause <pascal.krause@sap.com>
8f75544 to8b15f85Compare
…Repository
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained inhttps://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines:https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines