Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ensure pages/500 handles cache-control as expected (#72050)#72110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ijjk merged 2 commits into14-2-1fromijjk/backport-500-cache-fix
Nov 5, 2024

Conversation

@ijjk
Copy link
Member

Whenpages/500 usesgetStaticProps we can honor statically generating the page but we can't send aCache-Control withstale-while-revalidate as we shouldn't be caching errored pages ever. This ensures we handle that case and add a regression test for it.

When `pages/500` uses `getStaticProps` we can honor staticallygenerating the page but we can't send a `Cache-Control` with`stale-while-revalidate` as we shouldn't be caching errored pages ever.This ensures we handle that case and add a regression test for it.
@ijjkijjk changed the titlebackport: Ensure pages/500 handles cache-control as expected (#72050)Ensure pages/500 handles cache-control as expected (#72050)Oct 30, 2024
@ijjkijjk requested a review fromztannerOctober 30, 2024 22:12
@ijjk
Copy link
MemberAuthor

ijjk commentedOct 30, 2024•
edited
Loading

Stats from current PR

Default Build
General Overall increase⚠️
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
buildDuration16.3s14.7sN/A
buildDurationCached8.4s6.3sN/A
nodeModulesSize200 MB200 MB⚠️ +640 B
nextStartRea..uration (ms)402ms405msN/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
1a9f679d-HASH.js gzip53.7 kB53.7 kBN/A
5428.HASH.js gzip181 B180 BN/A
6067-HASH.js gzip5.06 kB5.06 kBN/A
6428-HASH.js gzip31.6 kB31.6 kBN/A
framework-HASH.js gzip44.9 kB44.9 kB✓
main-app-HASH.js gzip242 B245 BN/A
main-HASH.js gzip32.3 kB32.3 kBN/A
webpack-HASH.js gzip1.68 kB1.68 kBN/A
Overall change44.9 kB44.9 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
polyfills-HASH.js gzip39.4 kB39.4 kB✓
Overall change39.4 kB39.4 kB✓
Client Pages
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
_app-HASH.js gzip196 B196 B✓
_error-HASH.js gzip184 B185 BN/A
amp-HASH.js gzip502 B504 BN/A
css-HASH.js gzip321 B324 BN/A
dynamic-HASH.js gzip1.82 kB1.82 kBN/A
edge-ssr-HASH.js gzip258 B257 BN/A
head-HASH.js gzip352 B352 B✓
hooks-HASH.js gzip371 B372 BN/A
image-HASH.js gzip4.23 kB4.23 kBN/A
index-HASH.js gzip259 B257 BN/A
link-HASH.js gzip2.67 kB2.68 kBN/A
routerDirect..HASH.js gzip316 B314 BN/A
script-HASH.js gzip385 B386 BN/A
withRouter-HASH.js gzip311 B310 BN/A
1afbb74e6ecf..834.css gzip106 B106 B✓
Overall change654 B654 B✓
Client Build Manifests
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
_buildManifest.js gzip483 B481 BN/A
Overall change0 B0 B✓
Rendered Page Sizes
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
index.html gzip529 B527 BN/A
link.html gzip542 B539 BN/A
withRouter.html gzip525 B522 BN/A
Overall change0 B0 B✓
Edge SSR bundle Size
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
edge-ssr.js gzip95.5 kB95.5 kBN/A
page.js gzip3.06 kB3.06 kBN/A
Overall change0 B0 B✓
Middleware size
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
middleware-b..fest.js gzip656 B659 BN/A
middleware-r..fest.js gzip156 B154 BN/A
middleware.js gzip25.5 kB25.5 kBN/A
edge-runtime..pack.js gzip839 B839 B✓
Overall change839 B839 B✓
Next Runtimes
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
app-page-exp...dev.js gzip171 kB171 kB✓
app-page-exp..prod.js gzip98.3 kB98.3 kB✓
app-page-tur..prod.js gzip100 kB100 kB✓
app-page-tur..prod.js gzip94.3 kB94.3 kB✓
app-page.run...dev.js gzip145 kB145 kB✓
app-page.run..prod.js gzip92.8 kB92.8 kB✓
app-route-ex...dev.js gzip22.1 kB22.1 kB✓
app-route-ex..prod.js gzip15.5 kB15.5 kB✓
app-route-tu..prod.js gzip15.5 kB15.5 kB✓
app-route-tu..prod.js gzip15.2 kB15.2 kB✓
app-route.ru...dev.js gzip21.7 kB21.7 kB✓
app-route.ru..prod.js gzip15.2 kB15.2 kB✓
pages-api-tu..prod.js gzip9.58 kB9.58 kB✓
pages-api.ru...dev.js gzip9.85 kB9.85 kB✓
pages-api.ru..prod.js gzip9.57 kB9.57 kB✓
pages-turbo...prod.js gzip22.5 kB22.5 kB✓
pages.runtim...dev.js gzip23.2 kB23.2 kB✓
pages.runtim..prod.js gzip22.5 kB22.5 kB✓
server.runti..prod.js gzip51.6 kB51.6 kBN/A
Overall change904 kB904 kB✓
build cache
vercel/next.js 14-2-1vercel/next.js ijjk/backport-500-cache-fixChange
0.pack gzip1.61 MB1.6 MBN/A
index.pack gzip113 kB113 kBN/A
Overall change0 B0 B✓
Diff details
Diff formiddleware.js

Diff too large to display

Diff foredge-ssr.js

Diff too large to display

Diff forserver.runtime.prod.js

Diff too large to display

Commit:f80d32e

@ijjkijjk merged commitc7f7de9 into14-2-1Nov 5, 2024
51 of 56 checks passed
@ijjkijjk deleted the ijjk/backport-500-cache-fix branchNovember 5, 2024 22:55
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ztannerztannerztanner approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk@ztanner
[8]ページ先頭
©2009-2025 Movatter.jp