Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

examples/with-styled-components: Fix missing peerDependency#16532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 3 commits intovercel:canaryfromsimnalamburt:patch-1
Aug 25, 2020

Conversation

@simnalamburt
Copy link
Contributor

@ijjkijjk added the examplesIssue was opened via the examples template. labelAug 24, 2020
@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarysimnalamburt/next.js patch-1Change
buildDuration11.1s11.3s⚠️ +188ms
nodeModulesSize57.5 MB57.5 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarysimnalamburt/next.js patch-1Change
/ failed reqs00✓
/ total time (seconds)2.0851.951-0.13
/ avg req/sec1199.051281.3+82.25
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.0521.092⚠️ +0.04
/error-in-render avg req/sec2375.522288.66⚠️ -86.86
Client Bundles (main, webpack, commons)
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-7e72e5b..8b35.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e35d22e..dule.js gzip6.24 kB6.24 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.1 kB52.1 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarysimnalamburt/next.js patch-1Change
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarysimnalamburt/next.js patch-1Change
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarysimnalamburt/next.js patch-1Change
index.html gzip948 B948 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarysimnalamburt/next.js patch-1Change
buildDuration12.8s12.8s⚠️ +47ms
nodeModulesSize57.5 MB57.5 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-7e72e5b..8b35.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e35d22e..dule.js gzip6.24 kB6.24 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.1 kB52.1 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarysimnalamburt/next.js patch-1Change
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarysimnalamburt/next.js patch-1Change
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarysimnalamburt/next.js patch-1Change
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.28 MB5.28 MB✓
Commit:e0daaac

Copy link
Member

@lfadeslfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@simnalamburt Thank you!

lfades
lfades previously requested changesAug 24, 2020
Copy link
Member

@lfadeslfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just noticed something, can you please make the PR tocanary 🙏 .canary is our default branch and all PRs should go there.

@TimerTimer changed the base branch frommaster tocanaryAugust 25, 2020 04:30
@TimerTimer dismissedlfades’sstale reviewAugust 25, 2020 04:31

changed merge target

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarysimnalamburt/next.js patch-1Change
buildDuration12.2s11.9s-320ms
nodeModulesSize57.5 MB57.5 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarysimnalamburt/next.js patch-1Change
/ failed reqs00✓
/ total time (seconds)2.1092.135⚠️ +0.03
/ avg req/sec1185.611171.16⚠️ -14.45
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.2861.33⚠️ +0.04
/error-in-render avg req/sec1943.291880.35⚠️ -62.94
Client Bundles (main, webpack, commons)
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-7e72e5b..8b35.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e35d22e..dule.js gzip6.24 kB6.24 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.1 kB52.1 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarysimnalamburt/next.js patch-1Change
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarysimnalamburt/next.js patch-1Change
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarysimnalamburt/next.js patch-1Change
index.html gzip948 B948 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarysimnalamburt/next.js patch-1Change
buildDuration13.4s13.2s-250ms
nodeModulesSize57.5 MB57.5 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-7e72e5b..8b35.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e35d22e..dule.js gzip6.24 kB6.24 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.1 kB52.1 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarysimnalamburt/next.js patch-1Change
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarysimnalamburt/next.js patch-1Change
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarysimnalamburt/next.js patch-1Change
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarysimnalamburt/next.js patch-1Change
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.28 MB5.28 MB✓
Commit:e9b3dc0

@kodiakhqkodiakhqbot merged commit35a90d0 intovercel:canaryAug 25, 2020
@simnalamburt
Copy link
ContributorAuthor

Just noticed something, can you please make the PR tocanary 🙏 .canary is our default branch and all PRs should go there.

Oops I didn't noticed that!

changed merge target

Thanks!

@simnalamburtsimnalamburt deleted the patch-1 branchAugust 25, 2020 08:35
@vercelvercel locked asresolvedand limited conversation to collaboratorsJan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@TimerTimerTimer approved these changes

@lfadeslfadeslfades left review comments

@chibicodechibicodeAwaiting requested review from chibicode

@ijjkijjkAwaiting requested review from ijjk

@timneutkenstimneutkensAwaiting requested review from timneutkens

Assignees

No one assigned

Labels

examplesIssue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simnalamburt@ijjk@Timer@lfades
[8]ページ先頭
©2009-2025 Movatter.jp