Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ensure unknown static paths 404 for data request#16401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 3 commits intovercel:canaryfromTimer:correctly-404-data-request
Aug 20, 2020

Conversation

@Timer
Copy link
Member

We were accidentally allowing data requests to be rendered unconditionally. Instead, we should also check them against the staticPaths result and 404 when appropriate.

Fixes#15383

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
buildDuration11.5s12s⚠️ +483ms
nodeModulesSize57.4 MB57.4 MB⚠️ +72 B
Page Load Tests Overall decrease⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
/ failed reqs00✓
/ total time (seconds)2.2232.37⚠️ +0.15
/ avg req/sec1124.361055.06⚠️ -69.3
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.381.372-0.01
/error-in-render avg req/sec1810.981821.59+10.61
Client Bundles (main, webpack, commons)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
index.html gzip947 B947 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General Overall increase⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
buildDuration13.5s13.3s-251ms
nodeModulesSize57.4 MB57.4 MB⚠️ +72 B
Client Bundles (main, webpack, commons)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:878fd21

@ijjk
Copy link
Member

Failing test suites

Commit:878fd21

test/integration/prerender/test/index.test.js

  • SSG Prerender > enumlated serverless mode > should not return data for fallback: false and missing dynamic page
Expand output

● SSG Prerender › enumlated serverless mode › should not return data for fallback: false and missing dynamic page

expect(received).toBe(expected) // Object.is equalityExpected: 404Received: 200  582 |       `/_next/data/${buildId}/dynamic/oopsie.json`  583 |     )> 584 |     expect(res1.status).toBe(404)      |                         ^  585 |   586 |     await waitFor(500)  587 |   at Object.<anonymous> (integration/prerender/test/index.test.js:584:25)      at runMicrotasks (<anonymous>)

@TimerTimer requested a review fromijjkAugust 20, 2020 17:00
@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General Overall increase⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
buildDuration12.4s12.7s⚠️ +269ms
nodeModulesSize57.4 MB57.4 MB⚠️ +72 B
Page Load Tests Overall increase ✓
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
/ failed reqs00✓
/ total time (seconds)2.2562.235-0.02
/ avg req/sec1108.121118.45+10.33
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.2461.246✓
/error-in-render avg req/sec2005.872005.67⚠️ -0.2
Client Bundles (main, webpack, commons)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
index.html gzip947 B947 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General Overall increase⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
buildDuration14.7s14s-748ms
nodeModulesSize57.4 MB57.4 MB⚠️ +72 B
Client Bundles (main, webpack, commons)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:a6b4e28

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
buildDuration12.7s12.8s⚠️ +87ms
nodeModulesSize57.4 MB57.4 MB⚠️ +72 B
Page Load Tests Overall decrease⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
/ failed reqs00✓
/ total time (seconds)2.5482.578⚠️ +0.03
/ avg req/sec981.27969.83⚠️ -11.44
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.5141.56⚠️ +0.05
/error-in-render avg req/sec1650.921602.65⚠️ -48.27
Client Bundles (main, webpack, commons)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
index.html gzip947 B947 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General Overall increase⚠️
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
buildDuration14.1s13.7s-422ms
nodeModulesSize57.4 MB57.4 MB⚠️ +72 B
Client Bundles (main, webpack, commons)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canaryTimer/next.js correctly-404-data-requestChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:844899b

@kodiakhqkodiakhqbot merged commitec70096 intovercel:canaryAug 20, 2020
@TimerTimer deleted the correctly-404-data-request branchAugust 20, 2020 18:03
@vercelvercel locked asresolvedand limited conversation to collaboratorsJan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ijjkijjkijjk approved these changes

@lfadeslfadesAwaiting requested review from lfades

@timneutkenstimneutkensAwaiting requested review from timneutkens

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generating static pages even with no paths and fallback:false

2 participants

@Timer@ijjk
[8]ページ先頭
©2009-2025 Movatter.jp