Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: upgrade react-intl workflow in example#16215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 7 commits intovercel:canaryfromlonglho:react-intl
Aug 27, 2020
Merged

feat: upgrade react-intl workflow in example#16215

kodiakhq merged 7 commits intovercel:canaryfromlonglho:react-intl
Aug 27, 2020

Conversation

@longlho
Copy link
Contributor

@longlholonglho commentedAug 15, 2020•
edited
Loading

Changes:

simontaisne reacted with thumbs up emoji
@ijjkijjk added the examplesIssue was opened via the examples template. labelAug 15, 2020
@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration12s12.5s⚠️ +467ms
nodeModulesSize57.3 MB57.3 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.1812.1820
/ avg req/sec1146.481145.8⚠️ -0.68
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.1551.32⚠️ +0.17
/error-in-render avg req/sec2165.361893.96⚠️ -271.4
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip947 B947 B✓
link.html gzip955 B955 B✓
withRouter.html gzip942 B942 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration13.6s13.7s⚠️ +123ms
nodeModulesSize57.3 MB57.3 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.27 MB5.27 MB✓
Commit:30fed18

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration14.4s14.7s⚠️ +255ms
nodeModulesSize57.3 MB57.3 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.5242.401-0.12
/ avg req/sec990.351041.36+51.01
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.3211.406⚠️ +0.08
/error-in-render avg req/sec1892.41778.49⚠️ -113.91
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip947 B947 B✓
link.html gzip955 B955 B✓
withRouter.html gzip942 B942 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration15.2s16s⚠️ +769ms
nodeModulesSize57.3 MB57.3 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.27 MB5.27 MB✓
Commit:d495cee

@lfades
Copy link
Member

@longlho 👋 Hi there thank you for the PR.

Can you provide a description on how this changes improve the current example?, that would help me with the review as some of the changes aren't very clear to me 🙏

@longlho
Copy link
ContributorAuthor

longlho commentedAug 18, 2020•
edited
Loading

@lfades my dynamic import mostly works but it seems thatApp.getInitialProps doesn't get triggered the 1st time the app is mounted? I tried a breakpoint in there and it doesn't get hit unless I do a client side nav.

I've updated the PR description as well.

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration10.7s11.3s⚠️ +633ms
nodeModulesSize57.6 MB57.6 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)1.7491.968⚠️ +0.22
/ avg req/sec1429.531270.45⚠️ -159.08
/error-in-render failed reqs00✓
/error-in-render total time (seconds)0.9961.24⚠️ +0.24
/error-in-render avg req/sec25112015.8⚠️ -495.2
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..aa9e.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-c6e605d..8738.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-b606df5..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-00b8972..6e4e.js gzip1.3 kB1.3 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.7 kB7.7 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-72c64d9..dule.js gzip1.27 kB1.27 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.36 kB5.36 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip946 B946 B✓
link.html gzip952 B952 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration13.3s13.1s-205ms
nodeModulesSize57.6 MB57.6 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..aa9e.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-c6e605d..8738.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-b606df5..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-00b8972..6e4e.js gzip1.3 kB1.3 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.7 kB7.7 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-72c64d9..dule.js gzip1.27 kB1.27 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.36 kB5.36 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:0d6ffc0

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration12.9s12.7s-152ms
nodeModulesSize57.6 MB57.6 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.2652.237-0.03
/ avg req/sec1103.741117.64+13.9
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.2511.241-0.01
/error-in-render avg req/sec1998.322015.14+16.82
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..aa9e.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-c6e605d..8738.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-b606df5..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-00b8972..6e4e.js gzip1.3 kB1.3 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.7 kB7.7 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-72c64d9..dule.js gzip1.27 kB1.27 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.36 kB5.36 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip946 B946 B✓
link.html gzip952 B952 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration14.6s14.1s-503ms
nodeModulesSize57.6 MB57.6 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..aa9e.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-c6e605d..8738.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-b606df5..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-00b8972..6e4e.js gzip1.3 kB1.3 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.7 kB7.7 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-72c64d9..dule.js gzip1.27 kB1.27 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.36 kB5.36 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:fc51425

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration13.6s13.8s⚠️ +253ms
nodeModulesSize57.7 MB57.7 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.5952.642⚠️ +0.05
/ avg req/sec963.32946.11⚠️ -17.21
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.5881.66⚠️ +0.07
/error-in-render avg req/sec1574.221506.18⚠️ -68.04
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-512d5b9..081a.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-1203ff1..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip949 B949 B✓
link.html gzip955 B955 B✓
withRouter.html gzip940 B940 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration15.8s15.8s-51ms
nodeModulesSize57.7 MB57.7 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-512d5b9..081a.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-1203ff1..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:02d02f8

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration13s13s-19ms
nodeModulesSize57.4 MB57.4 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.5212.399-0.12
/ avg req/sec991.681042.25+50.57
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.4941.45-0.04
/error-in-render avg req/sec1673.841723.96+50.12
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip947 B947 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration14.9s14.9s⚠️ +45ms
nodeModulesSize57.4 MB57.4 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:4e1b3aa

@lfades
Copy link
Member

lfades commentedAug 20, 2020•
edited
Loading

@longlho Could you send a DM to Tim Neutkens on Twitter (https://twitter.com/timneutkens) 🙏 - We would like to talk more about Formatjs and Next.js as we're currently working towards built-in i18n support.

longlho reacted with thumbs up emoji

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration13.5s13.5s⚠️ +11ms
nodeModulesSize57.4 MB57.4 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.572.471-0.1
/ avg req/sec972.91011.56+38.66
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.5711.619⚠️ +0.05
/error-in-render avg req/sec1591.781544.38⚠️ -47.4
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip947 B947 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration15.8s15.1s-715ms
nodeModulesSize57.4 MB57.4 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:fc3ecaa

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration10.7s10.1s-571ms
nodeModulesSize57.4 MB57.4 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)1.8892.033⚠️ +0.14
/ avg req/sec1323.711229.88⚠️ -93.83
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.0831.054-0.03
/error-in-render avg req/sec2307.682372.35+64.67
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip947 B947 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration12.2s12.2s-9ms
nodeModulesSize57.4 MB57.4 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-44ad070..7dbf.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-6707cd9..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:f5ac3fa

@lfades
Copy link
Member

@longlho What's theserver.ts for now? I don't see it being used.

@longlho
Copy link
ContributorAuthor

@lfades is there a way to have custom server in TypeScript and usenext CLI? or do u have to manually compile it w/tsc & invoke it?

@lfades
Copy link
Member

@longlho You would have to do it manually.

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration10.9s10.7s-131ms
nodeModulesSize57.5 MB57.5 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.0252.001-0.02
/ avg req/sec1234.851249.17+14.32
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.0921.052-0.04
/error-in-render avg req/sec2288.652376.26+87.61
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-7e72e5b..8b35.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e35d22e..dule.js gzip6.24 kB6.24 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.1 kB52.1 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip948 B948 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration12.4s12.5s⚠️ +180ms
nodeModulesSize57.5 MB57.5 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-7e72e5b..8b35.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e35d22e..dule.js gzip6.24 kB6.24 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.1 kB52.1 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.28 MB5.28 MB✓
Commit:386a51a

Copy link
Member

@lfadeslfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@longlho Thank you!

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration9.6s9.7s⚠️ +134ms
nodeModulesSize57.5 MB57.5 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)1.8011.841⚠️ +0.04
/ avg req/sec1387.891357.91⚠️ -29.98
/error-in-render failed reqs00✓
/error-in-render total time (seconds)0.9561.016⚠️ +0.06
/error-in-render avg req/sec26142460.86⚠️ -153.14
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-ce79c9a..12c9.js gzip7.36 kB7.36 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.4 kB57.4 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-9973c26..dule.js gzip6.42 kB6.42 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.3 kB52.3 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip972 B972 B✓
link.html gzip978 B978 B✓
withRouter.html gzip964 B964 B✓
Overall change2.91 kB2.91 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration10.7s11s⚠️ +231ms
nodeModulesSize57.5 MB57.5 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-ce79c9a..12c9.js gzip7.36 kB7.36 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.4 kB57.4 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-9973c26..dule.js gzip6.42 kB6.42 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.3 kB52.3 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.22 kB4.22 kB✓
hooks.html3.86 kB3.86 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.28 MB5.28 MB✓
Commit:69a7f44

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration13.8s14.4s⚠️ +625ms
nodeModulesSize57.5 MB57.5 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarylonglho/next.js react-intlChange
/ failed reqs00✓
/ total time (seconds)2.6372.743⚠️ +0.11
/ avg req/sec948.02911.27⚠️ -36.75
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.5791.714⚠️ +0.14
/error-in-render avg req/sec1583.011458.89⚠️ -124.12
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-ce79c9a..12c9.js gzip7.36 kB7.36 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.4 kB57.4 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-9973c26..dule.js gzip6.42 kB6.42 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.3 kB52.3 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarylonglho/next.js react-intlChange
index.html gzip972 B972 B✓
link.html gzip978 B978 B✓
withRouter.html gzip964 B964 B✓
Overall change2.91 kB2.91 kB✓
Serverless Mode
General
vercel/next.js canarylonglho/next.js react-intlChange
buildDuration15.7s15.9s⚠️ +202ms
nodeModulesSize57.5 MB57.5 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..7f47.js gzip10.3 kB10.3 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-ce79c9a..12c9.js gzip7.36 kB7.36 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.4 kB57.4 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarylonglho/next.js react-intlChange
677f882d2ed8..dule.js gzip6.15 kB6.15 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-9973c26..dule.js gzip6.42 kB6.42 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52.3 kB52.3 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarylonglho/next.js react-intlChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarylonglho/next.js react-intlChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-28298..e0c9.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarylonglho/next.js react-intlChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-65c8a..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarylonglho/next.js react-intlChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarylonglho/next.js react-intlChange
_error.js1.03 MB1.03 MB✓
404.html4.22 kB4.22 kB✓
hooks.html3.86 kB3.86 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.28 MB5.28 MB✓
Commit:1f1ccfa

@kodiakhqkodiakhqbot merged commit5a478b4 intovercel:canaryAug 27, 2020
@simontaisne
Copy link

Hi@longlho, thanks for updating the example. A few remarks though:

  • The extracted message ids don't match the ones produced in the.next cache. The compiled langs are therefore not used in production.
{"65a8e":"Hello, World!",}
__jsx("p",null,__jsx(react_intl__WEBPACK_IMPORTED_MODULE_1__["FormattedMessage"],{id:"N015Sp",defaultMessage:[{"type":0,"value":"Hello, World!"}]}))

  • The translation happens only client side.

  • When navigating to a different page the locale resets toen.

@longlho
Copy link
ContributorAuthor

Can you make a GH issue and just assign to me?

simontaisne reacted with thumbs up emoji

@simontaisne
Copy link

Thanks@longlho! I've created the issue here#16689, but can't seem to assign you myself!

@longlholonglho deleted the react-intl branchAugust 30, 2020 02:12
@thuringia
Copy link

@longlho Thanks for updating the example, this is quite a bit simpler than before.

I was wondering, if it is possible to replace the custom server to make this usable with serverless mode?
Right now, I'm sacrificing proper language detection and SSR by doing this client-side, which is not ideal. This is required for deploying to Netlify or Vercel though.
Furthermoreblitz-js/blitz#279 seems to lean towardsnext-i18next due to "better" integration with Next.js. I'd prefer usingreact-intl, as I find it to be much superior

@longlho
Copy link
ContributorAuthor

@thuringia would you mind creating a new GH issue & cc me?

@thuringia
Copy link

@longlho I created#16752 for this. Please let me know if the description needs updating, etc.

@vercelvercel locked asresolvedand limited conversation to collaboratorsJan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lfadeslfadeslfades approved these changes

@chibicodechibicodeAwaiting requested review from chibicode

@ijjkijjkAwaiting requested review from ijjk

@TimerTimerAwaiting requested review from Timer

@timneutkenstimneutkensAwaiting requested review from timneutkens

+1 more reviewer

@jonespenjonespenjonespen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examplesIssue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@longlho@ijjk@lfades@simontaisne@thuringia@jonespen
[8]ページ先頭
©2009-2025 Movatter.jp