Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Handle cases whereconfig is exported after its declaration#16211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 5 commits intovercel:canaryfromkevva:config-var-before-export
Aug 17, 2020

Conversation

@kevva
Copy link
Contributor

AMP will still not work correctly when switching between non-AMP and AMP pages in development mode because ofhttps://github.com/vercel/next.js/blob/canary/packages/next/build/babel/plugins/next-page-config.ts#L116-L120.

Fixes#15704.

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General Overall increase⚠️
vercel/next.js canarykevva/next.js config-var-before-exportChange
buildDuration14.1s14s-100ms
nodeModulesSize57.3 MB57.3 MB⚠️ +980 B
Page Load Tests Overall increase ✓
vercel/next.js canarykevva/next.js config-var-before-exportChange
/ failed reqs00✓
/ total time (seconds)2.5662.53-0.04
/ avg req/sec974.36988.15+13.79
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.5431.475-0.07
/error-in-render avg req/sec1619.751694.46+74.71
Client Bundles (main, webpack, commons)
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarykevva/next.js config-var-before-exportChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarykevva/next.js config-var-before-exportChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Rendered Page Sizes
vercel/next.js canarykevva/next.js config-var-before-exportChange
index.html gzip947 B947 B✓
link.html gzip955 B955 B✓
withRouter.html gzip942 B942 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General Overall increase⚠️
vercel/next.js canarykevva/next.js config-var-before-exportChange
buildDuration16.1s16s-123ms
nodeModulesSize57.3 MB57.3 MB⚠️ +980 B
Client Bundles (main, webpack, commons)
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarykevva/next.js config-var-before-exportChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarykevva/next.js config-var-before-exportChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Serverless bundles
vercel/next.js canarykevva/next.js config-var-before-exportChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.27 MB5.27 MB✓
Commit:83a33e1

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General Overall increase⚠️
vercel/next.js canarykevva/next.js config-var-before-exportChange
buildDuration12.4s12.2s-266ms
nodeModulesSize57.3 MB57.3 MB⚠️ +919 B
Page Load Tests Overall increase ✓
vercel/next.js canarykevva/next.js config-var-before-exportChange
/ failed reqs00✓
/ total time (seconds)2.2572.337⚠️ +0.08
/ avg req/sec1107.861069.83⚠️ -38.03
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.4181.359-0.06
/error-in-render avg req/sec1763.021839.48+76.46
Client Bundles (main, webpack, commons)
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarykevva/next.js config-var-before-exportChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarykevva/next.js config-var-before-exportChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Rendered Page Sizes
vercel/next.js canarykevva/next.js config-var-before-exportChange
index.html gzip947 B947 B✓
link.html gzip955 B955 B✓
withRouter.html gzip942 B942 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General Overall increase⚠️
vercel/next.js canarykevva/next.js config-var-before-exportChange
buildDuration13.8s13.5s-298ms
nodeModulesSize57.3 MB57.3 MB⚠️ +919 B
Client Bundles (main, webpack, commons)
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..c139.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-52b3964..e4b8.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.9 kB56.9 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..dule.js gzip6.12 kB6.12 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-af2596f..dule.js gzip5.82 kB5.82 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.8 kB51.8 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarykevva/next.js config-var-before-exportChange
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarykevva/next.js config-var-before-exportChange
_buildManifest.js gzip321 B321 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change650 B650 B✓
Serverless bundles
vercel/next.js canarykevva/next.js config-var-before-exportChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.27 MB5.27 MB✓
Commit:48501a9

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General Overall increase⚠️
vercel/next.js canarykevva/next.js config-var-before-exportChange
buildDuration12.4s11.8s-532ms
nodeModulesSize57.6 MB57.6 MB⚠️ +3.05 kB
Page Load Tests Overall increase ✓
vercel/next.js canarykevva/next.js config-var-before-exportChange
/ failed reqs00✓
/ total time (seconds)2.141.979-0.16
/ avg req/sec1168.131263.08+94.95
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.1761.061-0.11
/error-in-render avg req/sec2125.962357.03+231.07
Client Bundles (main, webpack, commons)
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..b4e6.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-8c9d3f7..4367.js gzip6.72 kB6.72 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change56.7 kB56.7 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..dule.js gzip6.08 kB6.08 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e89c24f..dule.js gzip5.79 kB5.79 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change51.6 kB51.6 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarykevva/next.js config-var-before-exportChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-00b8972..6e4e.js gzip1.3 kB1.3 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.7 kB7.7 kB✓
Client Pages Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-72c64d9..dule.js gzip1.27 kB1.27 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.36 kB5.36 kB✓
Client Build Manifests
vercel/next.js canarykevva/next.js config-var-before-exportChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Rendered Page Sizes
vercel/next.js canarykevva/next.js config-var-before-exportChange
index.html gzip948 B948 B✓
link.html gzip953 B953 B✓
withRouter.html gzip941 B941 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General Overall increase⚠️
vercel/next.js canarykevva/next.js config-var-before-exportChange
buildDuration12.9s12.7s-233ms
nodeModulesSize57.6 MB57.6 MB⚠️ +3.05 kB
Client Bundles (main, webpack, commons)
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..b4e6.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-8c9d3f7..4367.js gzip6.72 kB6.72 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change56.7 kB56.7 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
677f882d2ed8..dule.js gzip6.08 kB6.08 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e89c24f..dule.js gzip5.79 kB5.79 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change51.6 kB51.6 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarykevva/next.js config-var-before-exportChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-00b8972..6e4e.js gzip1.3 kB1.3 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.7 kB7.7 kB✓
Client Pages Modern
vercel/next.js canarykevva/next.js config-var-before-exportChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-72c64d9..dule.js gzip1.27 kB1.27 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.36 kB5.36 kB✓
Client Build Manifests
vercel/next.js canarykevva/next.js config-var-before-exportChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip330 B330 B✓
Overall change652 B652 B✓
Serverless bundles
vercel/next.js canarykevva/next.js config-var-before-exportChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.27 MB5.27 MB✓
Commit:58ce67b

Copy link
Member

@ijjkijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The changes and updated tests look good to me, thanks for the PR!

@kodiakhqkodiakhqbot merged commitaa4b87e intovercel:canaryAug 17, 2020
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull requestAug 20, 2020
@vercelvercel locked asresolvedand limited conversation to collaboratorsJan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ijjkijjkijjk approved these changes

@lfadeslfadesAwaiting requested review from lfades

@TimerTimerAwaiting requested review from Timer

@timneutkenstimneutkensAwaiting requested review from timneutkens

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Links from non-AMP pages to AMP pages causes broken pages

2 participants

@kevva@ijjk
[8]ページ先頭
©2009-2025 Movatter.jp