Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add stripPrefix of webpack://_N_E/#15955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 2 commits intovercel:canaryfromtm1000:patch-1
Aug 11, 2020
Merged

Conversation

@tm1000
Copy link
Contributor

@tm1000tm1000 commentedAug 6, 2020•
edited
Loading

In with-sentry add stripPrefix ofwebpack://_N_E/. This removes thewebpack://_N_E/ prefix from the stack trace which will help Sentry to understand what is "App Only" vs "Full"

I'll fully tested calling errors in browser and the stack traces are still aligned and linked correctly. This just gets rid of the extra data in the front which seems to be the same for everyone and I believe it comes from webpack 5 (?)

berrugo reacted with thumbs up emoji
In sentry add stripPrefix of webpack://_N_E/. This removes the "webpack://_N_E/" prefix from the stack trace which will help Sentry to understand what is "App Only" vs "Full"
@ijjkijjk added the examplesIssue was opened via the examples template. labelAug 6, 2020
@ijjk
Copy link
Member

ijjk commentedAug 6, 2020

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarytm1000/next.js patch-1Change
buildDuration13.5s13.1s-383ms
nodeModulesSize65.9 MB65.9 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarytm1000/next.js patch-1Change
/ failed reqs00✓
/ total time (seconds)2.6072.293-0.31
/ avg req/sec958.81090.37+131.57
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.3331.22-0.11
/error-in-render avg req/sec1874.992049.57+174.58
Client Bundles (main, webpack, commons)
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..795d.js gzip9.99 kB9.99 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-c30ac70..0d39.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.6 kB56.6 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..dule.js gzip5.89 kB5.89 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-61da9c7..dule.js gzip5.81 kB5.81 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.6 kB51.6 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarytm1000/next.js patch-1Change
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarytm1000/next.js patch-1Change
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-f4d2979..e57b.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarytm1000/next.js patch-1Change
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-653c74f..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarytm1000/next.js patch-1Change
_buildManifest.js gzip273 B273 B✓
_buildManife..dule.js gzip280 B280 B✓
Overall change553 B553 B✓
Rendered Page Sizes
vercel/next.js canarytm1000/next.js patch-1Change
index.html gzip946 B946 B✓
link.html gzip953 B953 B✓
withRouter.html gzip940 B940 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarytm1000/next.js patch-1Change
buildDuration15.1s14.5s-561ms
nodeModulesSize65.9 MB65.9 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..795d.js gzip9.99 kB9.99 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-c30ac70..0d39.js gzip6.74 kB6.74 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.6 kB56.6 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..dule.js gzip5.89 kB5.89 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-61da9c7..dule.js gzip5.81 kB5.81 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.6 kB51.6 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarytm1000/next.js patch-1Change
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarytm1000/next.js patch-1Change
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-f4d2979..e57b.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarytm1000/next.js patch-1Change
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-653c74f..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarytm1000/next.js patch-1Change
_buildManifest.js gzip273 B273 B✓
_buildManife..dule.js gzip280 B280 B✓
Overall change553 B553 B✓
Serverless bundles
vercel/next.js canarytm1000/next.js patch-1Change
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.26 MB5.26 MB✓
Commit:dd759ef

Copy link

@scefaliscefali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarytm1000/next.js patch-1Change
buildDuration11.5s11.4s-95ms
nodeModulesSize57.3 MB57.3 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarytm1000/next.js patch-1Change
/ failed reqs00✓
/ total time (seconds)2.3172.14-0.18
/ avg req/sec1078.881168.06+89.18
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.3961.298-0.1
/error-in-render avg req/sec1790.771926.39+135.62
Client Bundles (main, webpack, commons)
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..6aa6.js gzip10 kB10 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-9a7a5f4..661e.js gzip6.71 kB6.71 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.6 kB56.6 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..dule.js gzip5.92 kB5.92 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-d0ac695..dule.js gzip5.79 kB5.79 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.6 kB51.6 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarytm1000/next.js patch-1Change
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarytm1000/next.js patch-1Change
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarytm1000/next.js patch-1Change
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarytm1000/next.js patch-1Change
_buildManifest.js gzip273 B273 B✓
_buildManife..dule.js gzip279 B279 B✓
Overall change552 B552 B✓
Rendered Page Sizes
vercel/next.js canarytm1000/next.js patch-1Change
index.html gzip945 B945 B✓
link.html gzip954 B954 B✓
withRouter.html gzip939 B939 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarytm1000/next.js patch-1Change
buildDuration13.5s13.4s-47ms
nodeModulesSize57.3 MB57.3 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..6aa6.js gzip10 kB10 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
main-9a7a5f4..661e.js gzip6.71 kB6.71 kB✓
webpack-ccf5..276a.js gzip751 B751 B✓
Overall change56.6 kB56.6 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarytm1000/next.js patch-1Change
677f882d2ed8..dule.js gzip5.92 kB5.92 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
main-d0ac695..dule.js gzip5.79 kB5.79 kB✓
webpack-10c7..dule.js gzip751 B751 B✓
Overall change51.6 kB51.6 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarytm1000/next.js patch-1Change
polyfills-75..1629.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarytm1000/next.js patch-1Change
_app-874bd8a..0103.js gzip1.28 kB1.28 kB✓
_error-fa39c..ec40.js gzip3.45 kB3.45 kB✓
hooks-585f07..95a3.js gzip887 B887 B✓
index-c7b63f..fc02.js gzip227 B227 B✓
link-4c2bd9b..eadd.js gzip1.29 kB1.29 kB✓
routerDirect..ebc7.js gzip284 B284 B✓
withRouter-2..db68.js gzip284 B284 B✓
Overall change7.71 kB7.71 kB✓
Client Pages Modern
vercel/next.js canarytm1000/next.js patch-1Change
_app-97e743e..dule.js gzip626 B626 B✓
_error-b4004..dule.js gzip2.3 kB2.3 kB✓
hooks-696209..dule.js gzip387 B387 B✓
index-a4dd74..dule.js gzip226 B226 B✓
link-236a801..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-1..dule.js gzip282 B282 B✓
Overall change5.37 kB5.37 kB✓
Client Build Manifests
vercel/next.js canarytm1000/next.js patch-1Change
_buildManifest.js gzip273 B273 B✓
_buildManife..dule.js gzip279 B279 B✓
Overall change552 B552 B✓
Serverless bundles
vercel/next.js canarytm1000/next.js patch-1Change
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.06 MB1.06 MB✓
withRouter.js1.06 MB1.06 MB✓
Overall change5.26 MB5.26 MB✓
Commit:24046c6

@kodiakhqkodiakhqbot merged commit2301331 intovercel:canaryAug 11, 2020
@jasonwilliams
Copy link

@tm1000 what does the _N_E stand for and where does it come from?

@timneutkens
Copy link
Member

timneutkens commentedAug 13, 2020•
edited
Loading

It's the library name set by Next.js in the webpack config which is required for webpack 5. I already told the Sentry folks that this is likely a bug in their webpack plugin that it's not stripping out the library name 👍

tm1000 and soren121 reacted with thumbs up emoji

m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull requestAug 20, 2020
In with-sentry add stripPrefix of `webpack://_N_E/`. This removes the `webpack://_N_E/` prefix from the stack trace which will help Sentry to understand what is "App Only" vs "Full"I'll fully tested calling errors in browser and the stack traces are still aligned and linked correctly. This just gets rid of the extra data in the front which seems to be the same for everyone and I believe it comes from webpack 5 (?)
@vercelvercel locked asresolvedand limited conversation to collaboratorsJan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@timneutkenstimneutkenstimneutkens approved these changes

@chibicodechibicodeAwaiting requested review from chibicode

@ijjkijjkAwaiting requested review from ijjk

@lfadeslfadesAwaiting requested review from lfades

@TimerTimerAwaiting requested review from Timer

+1 more reviewer

@scefaliscefaliscefali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examplesIssue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tm1000@ijjk@jasonwilliams@timneutkens@scefali
[8]ページ先頭
©2009-2025 Movatter.jp