Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CNA: Add warning about permission#14889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 8 commits intovercel:canaryfrommatamatanot:cna-warning-permission
Aug 19, 2020

Conversation

@matamatanot
Copy link
Contributor

close#14744

screen_shot

I have some concerns.

  • import { isWriteable } from '../next/build/is-writeable'not fromcreate-next-app package.
  • The warning sentence is from npm. Not for Next.js. I'm not a native English speaker. I'd like to know the natural expression for this.

@ijjkijjk added the create-next-appRelated to our CLI tool for quickly starting a new Next.js application. labelJul 6, 2020
@ijjk
Copy link
Member

ijjk commentedJul 6, 2020

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration10.2s10.5s⚠️ +278ms
nodeModulesSize66.1 MB66.1 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)1.7011.661-0.04
/ avg req/sec1469.81505.12+35.32
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.0270.978-0.05
/error-in-render avg req/sec2433.522557.34+123.82
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
main-HASH.js gzip6.63 kB6.63 kB✓
webpack-HASH.js gzip751 B751 B✓
19b7e98f51cc..6834.js gzip10.7 kB10.7 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
main-HASH.module.js gzip5.71 kB5.71 kB✓
webpack-HASH..dule.js gzip751 B751 B✓
19b7e98f51cc..dule.js gzip7.09 kB7.09 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
Overall change52.7 kB52.7 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-HASH.js gzip26.4 kB26.4 kB✓
Overall change26.4 kB26.4 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip268 B268 B✓
_buildManife..dule.js gzip272 B272 B✓
Overall change540 B540 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip953 B953 B✓
link.html gzip959 B959 B✓
withRouter.html gzip945 B945 B✓
Overall change2.86 kB2.86 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration11.1s11s-103ms
nodeModulesSize66.1 MB66.1 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
main-HASH.js gzip6.63 kB6.63 kB✓
webpack-HASH.js gzip751 B751 B✓
19b7e98f51cc..6834.js gzip10.7 kB10.7 kB✓
framework.HASH.js gzip39.1 kB39.1 kB✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
main-HASH.module.js gzip5.71 kB5.71 kB✓
webpack-HASH..dule.js gzip751 B751 B✓
19b7e98f51cc..dule.js gzip7.09 kB7.09 kB✓
framework.HA..dule.js gzip39.1 kB39.1 kB✓
Overall change52.7 kB52.7 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-HASH.js gzip26.4 kB26.4 kB✓
Overall change26.4 kB26.4 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip268 B268 B✓
_buildManife..dule.js gzip272 B272 B✓
Overall change540 B540 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js876 kB876 kB✓
404.html4.17 kB4.17 kB✓
hooks.html3.79 kB3.79 kB✓
index.js876 kB876 kB✓
link.js915 kB915 kB✓
routerDirect.js908 kB908 kB✓
withRouter.js908 kB908 kB✓
Overall change4.49 MB4.49 MB✓
Commit:449d2fd

@ijjk
Copy link
Member

ijjk commentedJul 6, 2020

Failing test suites

Commit:449d2fd

test/integration/create-next-app/index.test.js

  • create next app > empty directory
  • create next app > valid example
  • create next app > should allow example with GitHub URL
  • create next app > should allow example with GitHub URL and example-path
  • create next app > should use --example-path over the file path in the GitHub URL
  • create next app > should fall back to default template
  • create next app > should allow an example named default
Expand output

● create next app › empty directory

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js empty-directory  58 |       await usingTempDir(async (cwd) => {  59 |         const projectName = 'empty-directory'> 60 |         const res = await runStarter(cwd, projectName)     |                     ^  61 |   62 |         expect(res.exitCode).toBe(0)  63 |         expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:60:21  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:58:7)

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css  90 |     await usingTempDir(async (cwd) => {  91 |       const projectName = 'valid-example'> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')     |                   ^  93 |       expect(res.exitCode).toBe(0)  94 |   95 |       expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:92:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages  109 |     await usingTempDir(async (cwd) => {  110 |       const projectName = 'github-app'> 111 |       const res = await run(      |                   ^  112 |         cwd,  113 |         projectName,  114 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:111:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages  135 |     await usingTempDir(async (cwd) => {  136 |       const projectName = 'github-example-path'> 137 |       const res = await run(      |                   ^  138 |         cwd,  139 |         projectName,  140 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:137:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages  163 |     await usingTempDir(async (cwd) => {  164 |       const projectName = 'github-example-path-2'> 165 |       const res = await run(      |                   ^  166 |         cwd,  167 |         projectName,  168 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:165:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

● create next app › should fall back to default template

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js fail-example --example __internal-testing-retry  212 |         }  213 | > 214 |         const res = await runExample(      |                     ^  215 |           'fail-example',  216 |           '--example',  217 |           '__internal-testing-retry'  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:214:21  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:194:7)

● create next app › should allow an example named default

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js default-example --example default  225 |     await usingTempDir(async (cwd) => {  226 |       const projectName = 'default-example'> 227 |       const res = await run(cwd, projectName, '--example', 'default')      |                   ^  228 |       expect(res.exitCode).toBe(0)  229 |   230 |       expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:227:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:225:5)

@matamatanotmatamatanot changed the titleCNA: Add warning about permission.CNA: Add warning about permissionJul 7, 2020
@ijjk
Copy link
Member

Failing test suites

Commit:9cc2884

test/integration/create-next-app/index.test.js

  • create next app > empty directory
  • create next app > valid example
  • create next app > should allow example with GitHub URL
  • create next app > should allow example with GitHub URL and example-path
  • create next app > should use --example-path over the file path in the GitHub URL
  • create next app > should fall back to default template
  • create next app > should allow an example named default
Expand output

● create next app › empty directory

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js empty-directory  58 |       await usingTempDir(async (cwd) => {  59 |         const projectName = 'empty-directory'> 60 |         const res = await runStarter(cwd, projectName)     |                     ^  61 |   62 |         expect(res.exitCode).toBe(0)  63 |         expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:60:21  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:58:7)

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css  90 |     await usingTempDir(async (cwd) => {  91 |       const projectName = 'valid-example'> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')     |                   ^  93 |       expect(res.exitCode).toBe(0)  94 |   95 |       expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:92:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages  109 |     await usingTempDir(async (cwd) => {  110 |       const projectName = 'github-app'> 111 |       const res = await run(      |                   ^  112 |         cwd,  113 |         projectName,  114 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:111:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages  135 |     await usingTempDir(async (cwd) => {  136 |       const projectName = 'github-example-path'> 137 |       const res = await run(      |                   ^  138 |         cwd,  139 |         projectName,  140 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:137:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages  163 |     await usingTempDir(async (cwd) => {  164 |       const projectName = 'github-example-path-2'> 165 |       const res = await run(      |                   ^  166 |         cwd,  167 |         projectName,  168 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:165:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

● create next app › should fall back to default template

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js fail-example --example __internal-testing-retry  212 |         }  213 | > 214 |         const res = await runExample(      |                     ^  215 |           'fail-example',  216 |           '--example',  217 |           '__internal-testing-retry'  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:214:21  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:194:7)

● create next app › should allow an example named default

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js default-example --example default  225 |     await usingTempDir(async (cwd) => {  226 |       const projectName = 'default-example'> 227 |       const res = await run(cwd, projectName, '--example', 'default')      |                   ^  228 |       expect(res.exitCode).toBe(0)  229 |   230 |       expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:227:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:225:5)

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration10.2s10.3s⚠️ +165ms
nodeModulesSize57.6 MB57.6 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)1.8941.890
/ avg req/sec1319.721323.04+3.32
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.041.071⚠️ +0.03
/error-in-render avg req/sec2403.972334.52⚠️ -69.45
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-1ea360d..8d32.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-ece3b39..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip947 B947 B✓
link.html gzip952 B952 B✓
withRouter.html gzip938 B938 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration11.7s11.6s-101ms
nodeModulesSize57.6 MB57.6 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-1ea360d..8d32.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-ece3b39..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:9cc2884

@ijjk
Copy link
Member

Failing test suites

Commit:530b91c

test/integration/create-next-app/index.test.js

  • create next app > empty directory
  • create next app > valid example
  • create next app > should allow example with GitHub URL
  • create next app > should allow example with GitHub URL and example-path
  • create next app > should use --example-path over the file path in the GitHub URL
  • create next app > should fall back to default template
  • create next app > should allow an example named default
Expand output

● create next app › empty directory

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js empty-directory  58 |       await usingTempDir(async (cwd) => {  59 |         const projectName = 'empty-directory'> 60 |         const res = await runStarter(cwd, projectName)     |                     ^  61 |   62 |         expect(res.exitCode).toBe(0)  63 |         expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:60:21  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:58:7)

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css  90 |     await usingTempDir(async (cwd) => {  91 |       const projectName = 'valid-example'> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')     |                   ^  93 |       expect(res.exitCode).toBe(0)  94 |   95 |       expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:92:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages  109 |     await usingTempDir(async (cwd) => {  110 |       const projectName = 'github-app'> 111 |       const res = await run(      |                   ^  112 |         cwd,  113 |         projectName,  114 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:111:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages  135 |     await usingTempDir(async (cwd) => {  136 |       const projectName = 'github-example-path'> 137 |       const res = await run(      |                   ^  138 |         cwd,  139 |         projectName,  140 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:137:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages  163 |     await usingTempDir(async (cwd) => {  164 |       const projectName = 'github-example-path-2'> 165 |       const res = await run(      |                   ^  166 |         cwd,  167 |         projectName,  168 |         '--example',  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:165:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

● create next app › should fall back to default template

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js fail-example --example __internal-testing-retry  212 |         }  213 | > 214 |         const res = await runExample(      |                     ^  215 |           'fail-example',  216 |           '--example',  217 |           '__internal-testing-retry'  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:214:21  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:194:7)

● create next app › should allow an example named default

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js default-example --example default  225 |     await usingTempDir(async (cwd) => {  226 |       const projectName = 'default-example'> 227 |       const res = await run(cwd, projectName, '--example', 'default')      |                   ^  228 |       expect(res.exitCode).toBe(0)  229 |   230 |       expect(  at makeError (../node_modules/execa/lib/error.js:58:11)  at handlePromise (../node_modules/execa/index.js:112:26)  at integration/create-next-app/index.test.js:227:19  at usingTempDir (integration/create-next-app/index.test.js:30:12)  at Object.<anonymous> (integration/create-next-app/index.test.js:225:5)

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration10.2s10.1s-105ms
nodeModulesSize57.6 MB57.6 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)1.821.853⚠️ +0.03
/ avg req/sec1373.871348.94⚠️ -24.93
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.0181.0220
/error-in-render avg req/sec2455.072445.54⚠️ -9.53
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-1ea360d..8d32.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-ece3b39..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip947 B947 B✓
link.html gzip952 B952 B✓
withRouter.html gzip938 B938 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration11.5s11.5s⚠️ +66ms
nodeModulesSize57.6 MB57.6 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-1ea360d..8d32.js gzip7.16 kB7.16 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-ece3b39..dule.js gzip6.18 kB6.18 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:530b91c

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration9.8s9.9s⚠️ +154ms
nodeModulesSize57.7 MB57.7 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)1.8081.863⚠️ +0.05
/ avg req/sec1382.951342.26⚠️ -40.69
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.0191.072⚠️ +0.05
/error-in-render avg req/sec2454.452331.91⚠️ -122.54
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-8da9cf5..55dc.js gzip7.18 kB7.18 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e458620..dule.js gzip6.2 kB6.2 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip947 B947 B✓
link.html gzip953 B953 B✓
withRouter.html gzip938 B938 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration11.1s11.6s⚠️ +500ms
nodeModulesSize57.7 MB57.7 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-8da9cf5..55dc.js gzip7.18 kB7.18 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e458620..dule.js gzip6.2 kB6.2 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:2d5e18e

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration12.8s12.8s-23ms
nodeModulesSize57.7 MB57.7 MB✓
Page Load Tests Overall decrease⚠️
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)2.4132.445⚠️ +0.03
/ avg req/sec1035.921022.48⚠️ -13.44
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.4511.486⚠️ +0.03
/error-in-render avg req/sec1722.841682.68⚠️ -40.16
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-8da9cf5..55dc.js gzip7.18 kB7.18 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e458620..dule.js gzip6.2 kB6.2 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip947 B947 B✓
link.html gzip953 B953 B✓
withRouter.html gzip938 B938 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration14.6s14.3s-335ms
nodeModulesSize57.7 MB57.7 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-8da9cf5..55dc.js gzip7.18 kB7.18 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.1 kB57.1 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-e458620..dule.js gzip6.2 kB6.2 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:5f46a01

Copy link
Member

@lfadeslfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@matamatanot Thank you for the PR and sorry for the late review, it was missing some changes and tests

@ijjk@Timer Could one of you do a review of the PR 🙏 . I updated it and I shouldn't review my own changes.

@ijjkijjk requested a review fromlfadesAugust 19, 2020 15:09
@lfadeslfades requested a review fromijjkAugust 19, 2020 16:46
@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration12.5s12.4s-136ms
nodeModulesSize57.7 MB57.7 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)2.2422.252⚠️ +0.01
/ avg req/sec1115.081110.07⚠️ -5.01
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.3161.247-0.07
/error-in-render avg req/sec1900.172004.61+104.44
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-512d5b9..081a.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-1203ff1..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip949 B949 B✓
link.html gzip955 B955 B✓
withRouter.html gzip940 B940 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration14.3s13.7s-590ms
nodeModulesSize57.7 MB57.7 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-512d5b9..081a.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-1203ff1..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:e5479a7

@ijjk
Copy link
Member

Stats from current PR

Default Server Mode (Increase detected⚠️)
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration12.2s12.5s⚠️ +267ms
nodeModulesSize57.7 MB57.7 MB✓
Page Load Tests Overall increase ✓
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
/ failed reqs00✓
/ total time (seconds)2.242.2410
/ avg req/sec1116.221115.78⚠️ -0.44
/error-in-render failed reqs00✓
/error-in-render total time (seconds)1.2311.207-0.02
/error-in-render avg req/sec2030.52071.2+40.7
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-512d5b9..081a.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-1203ff1..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Rendered Page Sizes
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
index.html gzip949 B949 B✓
link.html gzip955 B955 B✓
withRouter.html gzip940 B940 B✓
Overall change2.84 kB2.84 kB✓
Serverless Mode
General
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
buildDuration13.9s14s⚠️ +118ms
nodeModulesSize57.7 MB57.7 MB✓
Client Bundles (main, webpack, commons)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..4e55.js gzip10.2 kB10.2 kB✓
framework.HASH.js gzip39 kB39 kB✓
main-512d5b9..081a.js gzip7.2 kB7.2 kB✓
webpack-e067..f178.js gzip751 B751 B✓
Overall change57.2 kB57.2 kB✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
677f882d2ed8..dule.js gzip6.11 kB6.11 kB✓
framework.HA..dule.js gzip39 kB39 kB✓
main-1203ff1..dule.js gzip6.21 kB6.21 kB✓
webpack-07c5..dule.js gzip751 B751 B✓
Overall change52 kB52 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
polyfills-4b..e242.js gzip31 kB31 kB✓
Overall change31 kB31 kB✓
Client Pages
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-9a0b9e1..b37e.js gzip1.28 kB1.28 kB✓
_error-1464c..a26f.js gzip3.44 kB3.44 kB✓
hooks-89731c..c609.js gzip887 B887 B✓
index-17468f..5d83.js gzip227 B227 B✓
link-000f151..65d4.js gzip1.29 kB1.29 kB✓
routerDirect..924c.js gzip284 B284 B✓
withRouter-7..c13d.js gzip284 B284 B✓
Overall change7.69 kB7.69 kB✓
Client Pages Modern
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_app-75d3a82..dule.js gzip625 B625 B✓
_error-e550f..dule.js gzip2.29 kB2.29 kB✓
hooks-cbf13f..dule.js gzip387 B387 B✓
index-b9a643..dule.js gzip226 B226 B✓
link-4cfda7a..dule.js gzip1.26 kB1.26 kB✓
routerDirect..dule.js gzip284 B284 B✓
withRouter-f..dule.js gzip282 B282 B✓
Overall change5.35 kB5.35 kB✓
Client Build Manifests
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_buildManifest.js gzip322 B322 B✓
_buildManife..dule.js gzip329 B329 B✓
Overall change651 B651 B✓
Serverless bundles
vercel/next.js canarymatamatanot/next.js cna-warning-permissionChange
_error.js1.03 MB1.03 MB✓
404.html4.18 kB4.18 kB✓
hooks.html3.82 kB3.82 kB✓
index.js1.03 MB1.03 MB✓
link.js1.07 MB1.07 MB✓
routerDirect.js1.07 MB1.07 MB✓
withRouter.js1.07 MB1.07 MB✓
Overall change5.27 MB5.27 MB✓
Commit:896f7b1

@kodiakhqkodiakhqbot merged commit0226e78 intovercel:canaryAug 19, 2020
@matamatanotmatamatanot deleted the cna-warning-permission branchAugust 19, 2020 19:08
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull requestAug 20, 2020
closevercel#14744<img width="851" alt="screen_shot" src="https://user-images.githubusercontent.com/39780486/86603491-06bec800-bfdf-11ea-9928-ee85cbad86a7.png">I have some concerns.- `import { isWriteable } from '../next/build/is-writeable'` **not** from `create-next-app ` package.- The warning sentence is from npm. Not for Next.js. I'm not a native English speaker. I'd like to know the natural expression for this.
@vercelvercel locked asresolvedand limited conversation to collaboratorsJan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ijjkijjkijjk approved these changes

@TimerTimerAwaiting requested review from Timer

@timneutkenstimneutkensAwaiting requested review from timneutkens

@lfadeslfadesAwaiting requested review from lfades

Assignees

No one assigned

Labels

create-next-appRelated to our CLI tool for quickly starting a new Next.js application.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matamatanot@ijjk@lfades
[8]ページ先頭
©2009-2025 Movatter.jp