NotificationsYou must be signed in to change notification settings
Fork29.8k
Star135k

Commitb66c1d6

authored

Remove layout-router sticky/fixed debug warning (#85193)

Fixes an issue that reproduces due to a combination of the logforwarding logic alongside logging out an explicit element. We can addthis back in the future once our log forwarding library properly ignoresnon-enumerable properties.

1 parent96754b6 commitb66c1d6Copy full SHA for b66c1d6

File tree

2 files changed

-34

lines changed

packages/next/src/client/components
- layout-router.tsx
test/e2e/app-dir/router-autoscroll
- router-autoscroll.test.ts

2 files changed

-34

lines changed

`‎packages/next/src/client/components/layout-router.tsx‎`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -140,12 +140,6 @@ function shouldSkipElement(element: HTMLElement) {`
`140`	`140`	`// and will result in a situation we bail on scroll because of something like a fixed nav,`
`141`	`141`	`// even though the actual page content is offscreen`
`142`	`142`	`if(['sticky','fixed'].includes(getComputedStyle(element).position)){`
`143`		`-if(process.env.NODE_ENV==='development'){`
`144`		`-console.warn(`
`145`		-'Skipping auto-scroll behavior due to `position: sticky` or `position: fixed` on element:',
`146`		`-element`
`147`		`-)`
`148`		`-}`
`149`	`143`	`returntrue`
`150`	`144`	`}`
`151`	`145`

`‎test/e2e/app-dir/router-autoscroll/router-autoscroll.test.ts‎`

Lines changed: 0 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -197,20 +197,6 @@ describe('router autoscrolling on navigation', () => {`
`197`	`197`	`.click()`
`198`	`198`	`.waitForElementByCss('#content-that-is-visible')`
`199`	`199`	`awaitcheck(()=>browser.eval('window.scrollY'),0)`
`200`		`-`
`201`		`-if(isNextDev){`
`202`		`-// Check that we've logged a warning`
`203`		`-awaitcheck(async()=>{`
`204`		`-constlogs=awaitbrowser.log()`
`205`		`-returnlogs.some((log)=>`
`206`		`-log.message.includes(`
`207`		-'Skipping auto-scroll behavior due to `position: sticky` or `position: fixed` on element:'
`208`		`-)`
`209`		`-)`
`210`		`- ?'success'`
`211`		`- :undefined`
`212`		`-},'success')`
`213`		`-}`
`214`	`200`	`})`
`215`	`201`
`216`	`202`	`it('Should scroll to the top of the layout when the first child is position sticky',async()=>{`
`@@ -221,20 +207,6 @@ describe('router autoscrolling on navigation', () => {`
`221`	`207`	`.click()`
`222`	`208`	`.waitForElementByCss('#content-that-is-visible')`
`223`	`209`	`awaitcheck(()=>browser.eval('window.scrollY'),0)`
`224`		`-`
`225`		`-if(isNextDev){`
`226`		`-// Check that we've logged a warning`
`227`		`-awaitcheck(async()=>{`
`228`		`-constlogs=awaitbrowser.log()`
`229`		`-returnlogs.some((log)=>`
`230`		`-log.message.includes(`
`231`		-'Skipping auto-scroll behavior due to `position: sticky` or `position: fixed` on element:'
`232`		`-)`
`233`		`-)`
`234`		`- ?'success'`
`235`		`- :undefined`
`236`		`-},'success')`
`237`		`-}`
`238`	`210`	`})`
`239`	`211`
`240`	`212`	`it('Should apply scroll when loading.js is used',async()=>{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb66c1d6

File tree

2 files changed

2 files changed

`‎packages/next/src/client/components/layout-router.tsx‎`

`‎test/e2e/app-dir/router-autoscroll/router-autoscroll.test.ts‎`

0 commit comments