- Notifications
You must be signed in to change notification settings - Fork1.9k
Commitdf4f362
authored
fix(blackhole sink): implement end-to-end acknowledgements (#24283)
Addresses#24281The blackhole sink was consuming events without updating finalizer status,causing sources that depend on acknowledgements (like aws_s3 with SQS) tonever receive delivery confirmation. This resulted in SQS messages neverbeing deleted and queue depth growing indefinitely.Added proper finalizer handling by taking finalizers from events andmarking them as delivered after processing, matching the pattern usedby other sinks like console.Co-authored-by: sanjams2 <sanjams2@users.noreply.github.com>1 parentb9ad9b3 commitdf4f362
File tree
3 files changed
+11
-4
lines changed- changelog.d
- src/sinks/blackhole
3 files changed
+11
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | | - | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
| |||
0 commit comments
Comments
(0)