Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci(tests) Verify runtime deps#486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tony wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromci-test-runtime-deps
Open

Conversation

@tony
Copy link
Member

@tonytony commentedFeb 20, 2025•
edited by sourcery-aibot
Loading

Changes

  • Add runtime dependency check in CI usinguv run --no-dev
  • Run check before installing dev dependencies
  • Print package version and basic functionality test results
  • Document improvement inCHANGES

Summary by Sourcery

Add a CI job to verify runtime dependencies before installing dev dependencies. This ensures that the package functions correctly with only its runtime dependencies installed.

CI:

  • Add a CI job to verify runtime dependencies usinguv run --no-dev before installing dev dependencies.
  • The job prints the package version and runs a basic functionality test.

@sourcery-ai
Copy link

sourcery-aibot commentedFeb 20, 2025•
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new CI job to verify the project's runtime dependencies. It usesuv run --no-dev to ensure that only runtime dependencies are installed before running basic functionality tests. This helps catch issues related to missing runtime dependencies early in the development process.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

ChangeDetailsFiles
Added a CI job to verify runtime dependencies usinguv run --no-dev.
  • Added a new job named 'Test runtime dependencies'.
  • The job executesuv run --no-dev to check runtime dependencies.
  • The job prints the package version and runs a basic functionality test.
.github/workflows/tests.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment@sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with@sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write@sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write@sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment@sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment@sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment@sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment@sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment@sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access yourdashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-aisourcery-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey@tony - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider usingpython -m libvcs instead of importing all modules to verify the installation.
Here's what I looked at during the review
  • 🟢General issues: all looks good
  • 🟢Security: all looks good
  • 🟢Testing: all looks good
  • 🟢Complexity: all looks good
  • 🟢Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

sourcery-ai[bot] reacted with thumbs up emojisourcery-ai[bot] reacted with thumbs down emoji
@tonytonyforce-pushed theci-test-runtime-deps branch 2 times, most recently from936a2d0 to04faf16CompareFebruary 22, 2025 23:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tony
[8]ページ先頭
©2009-2025 Movatter.jp