- Notifications
You must be signed in to change notification settings - Fork11
pytest fixtures: hg / git configurations to session scope#475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedOct 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #475 +/- ##==========================================+ Coverage 64.17% 64.52% +0.34%========================================== Files 40 40 Lines 3713 3721 +8 Branches 788 789 +1 ==========================================+ Hits 2383 2401 +18+ Misses 793 782 -11- Partials 537 538 +1 ☔ View full report in Codecov by Sentry. |
a68d632 to3e4d41eCompareFixed 2 errors:- src/libvcs/pytest_plugin.py: 1 × RET504 (unnecessary-assign)- tests/sync/test_svn.py: 1 × COM812 (missing-trailing-comma)
7d6bc81 intomasterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Resolves#474
Problem
Issue#472 requires session-scoped fixtures.
Currently, we use
set_home,gitconfig, andhgconfigtomonkeypatch.setenv$HOME, pointing it to a temporary directory with user-specific configuration files. This ensures all subsequentgitandhgcommands automatically load these configurations.However,
monkeypatch.setenvdoesn't work with function-scoped fixtures.Improvement
Changes
pytest fixtures: Session-scoped
hgconfigandgitconfigThese are now set by
set_hgconfigandset_gitconfig, which setHGRCPATHandGIT_CONFIG, instead of overridingHOME.