NotificationsYou must be signed in to change notification settings
Fork11
Star56

mypy w/ reviewdog (experiment)#369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

tony wants to merge2 commits intomaster

base:master

Choose a base branch

frommypy-reviewdog

Open

mypy w/ reviewdog (experiment)#369

tony wants to merge2 commits intomasterfrommypy-reviewdog

Conversation

Copy link

Member

tony commentedMay 30, 2022

https://github.com/tsuyoshicho/action-mypy w/https://github.com/reviewdog/reviewdog

tony added2 commits

May 30, 2022 17:01

Revert "! squash more mypy"

84da4ef

This reverts commit078ebb7.

ci(tests): Add tsuyoshicho/action-mypy

26ef6e8

See also:https://github.com/tsuyoshicho/action-mypy

github-actionsbot reviewed

May 30, 2022

View reviewed changes

libvcs/_internal/run.py

		)

		all_output:list[str]= []
		all_output= []

Copy link

github-actionsbotMay 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚫[mypy]_{reported byreviewdog 🐶}
Need type annotation for "all_output" (hint: "all_output: List[] = ...")

Copy link

codecovbot commentedMay 30, 2022

Codecov Report

Merging#369 (26ef6e8) intomaster (7e24050) willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master     #369   +/-   ##=======================================  Coverage   70.35%   70.35%           =======================================  Files          21       21             Lines        1882     1882           =======================================  Hits         1324     1324             Misses        558      558

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7e24050...26ef6e8. Read thecomment docs.