NotificationsYou must be signed in to change notification settings
Fork11
Star56

Lazy imports (from django)#339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

tony wants to merge3 commits intomaster

base:master

Choose a base branch

fromlazy-imports

Open

Lazy imports (from django)#339

tony wants to merge3 commits intomasterfromlazy-imports

Conversation

Copy link

Member

tony commentedApr 30, 2022

No description provided.

tony added3 commits

April 30, 2022 04:17

tests(module_loading): Port tests from django 4.0 w/ touchups

a3a63b5

Remove django-specific stuff so they're generic. Use pytest for syspaths.See also:https://github.com/django/django/blob/4.0.4/django/utils/module_loading.py

feat(utils): module_loading.py (from django 4.x)

a752afe

See also:https://github.com/django/django/blob/4.0.4/django/utils/module_loading.py

🔧 setup.cfg(pytest): Skip test_module/ sample directory

eb7985a

Copy link

codecovbot commentedApr 30, 2022

Codecov Report

Merging#339 (eb7985a) intomaster (4fb953f) willdecrease coverage by1.70%.
The diff coverage is47.28%.

@@            Coverage Diff             @@##           master     #339      +/-   ##==========================================- Coverage   73.21%   71.50%   -1.71%==========================================  Files          23       30       +7       Lines        1833     1962     +129     ==========================================+ Hits         1342     1403      +61- Misses        491      559      +68

Impacted Files	Coverage Δ
tests/utils/test_module/another_bad_module.py	`0.00% <0.00%> (ø)`
tests/utils/test_module/another_good_module.py	`0.00% <0.00%> (ø)`
...tils/test_module/child_module/grandchild_module.py	`0.00% <0.00%> (ø)`
libvcs/utils/module_loading.py	`48.64% <48.64%> (ø)`
tests/utils/test_module/bad_module.py	`50.00% <50.00%> (ø)`
tests/utils/test_module_loading.py	`50.61% <50.61%> (ø)`
tests/utils/test_module/good_module.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4fb953f...eb7985a. Read thecomment docs.