Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Mini queryset replacement#330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
tony wants to merge2 commits intomasterfrommini-queryset
Closed

Mini queryset replacement#330

tony wants to merge2 commits intomasterfrommini-queryset

Conversation

@tony
Copy link
Member

@tonytony commentedApr 16, 2022
edited
Loading

We need a way to return a list of objects. Should be:

  • Simplicity over performance
  • Not meant for speed. ~100 objects.
  • Iterable as a list through a for loop
  • Iterable as a dictionary(pk, obj) via .items()
  • Support direct lookups via a pk (e.g. git remote name)
  • Support any (fixed) type of list item
  • Type annotated

Nice to have:

  • Should be comparable to other queryset objects

    Including inner data, if possible

  • One file

  • Simple

@codecov
Copy link

codecovbot commentedApr 17, 2022
edited
Loading

Codecov Report

Merging#330 (9a3ef73) intomaster (c97aa0d) willincrease coverage by0.79%.
The diff coverage is84.74%.

❗ Current head9a3ef73 differs from pull request most recent headc1649fe. Consider uploading reports for the commitc1649fe to get more accurate results

@@            Coverage Diff             @@##           master     #330      +/-   ##==========================================+ Coverage   72.51%   73.31%   +0.79%==========================================  Files          21       23       +2       Lines        1703     1821     +118     ==========================================+ Hits         1235     1335     +100- Misses        468      486      +18
Impacted FilesCoverage Δ
libvcs/utils/list_query.py83.17% <83.17%> (ø)
tests/utils/test_list_query.py100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec97aa0d...c1649fe. Read thecomment docs.

@tonytonyforce-pushed themini-queryset branch 16 times, most recently from4616e94 to7c1508aCompareApril 21, 2022 20:47
@tonytony mentioned this pull requestApr 22, 2022
@tonytonyforce-pushed themini-queryset branch 3 times, most recently froma71cd97 tof19688dCompareApril 22, 2022 23:36
@tony
Copy link
MemberAuthor

#334

@tonytony closed thisApr 22, 2022
@tonytony deleted the mini-queryset branchApril 22, 2022 23:47
@tonytony added this to thev0.12 milestoneMay 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Status: No status

Milestone

v0.12

Development

Successfully merging this pull request may close these issues.

2 participants

@tony

[8]ページ先頭

©2009-2025 Movatter.jp