Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.4k
Comments
fix(isLocale): add support for validation of more valid language tags#2189
Merged
profnandaa merged 1 commit intovalidatorjs:masterfromMar 27, 2023
Merged
Conversation
Codecov ReportBase:100.00% // Head:100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@## master #2189 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 106 106 Lines 2348 2359 +11 Branches 593 592 -1 =========================================+ Hits 2348 2359 +11
Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here. ☔ View full report at Codecov. |
profnandaa approved these changesMar 7, 2023
Member
profnandaa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for your contrib@kwahome ! 🎉
This was referencedJul 19, 2024
This was referencedAug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(isLocale): Add support for validation of more valid language tags
ImplementRFC 5646 compliant regex to validate language tags and locales.
Fix for#2100
Checklist