Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add dark mode support to website#38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sylvestre merged 6 commits intouutils:mainfromLouisDISPA:main
Feb 28, 2025
Merged

Conversation

LouisDISPA
Copy link
Contributor

Hello, I quickly did a dark mode to the website just for fun and see how complex it would be. This is a very simple implementation only in css. Feel free to close this PR if you don't want this feature or don't like it.

I'm happy to work more on it if you are interested in this feature like:

  • cleanup CSS variables
  • add a theme switcher button (would require some javascript)
  • test different colors

List of changes:

  • Use CSSprefers-color-scheme media queries
  • Create dark version of the logo for dark mode
  • Code block syntax highlighting
  • Syntax highlighting dark mode support
  • Update Zola to v0.20
  • Add hover state for links

Screenshots:

Capture d’écran 2025-02-17 à 22 09 41Capture d’écran 2025-02-17 à 22 09 50Capture d’écran 2025-02-17 à 22 10 05Capture d’écran 2025-02-17 à 22 10 23Capture d’écran 2025-02-17 à 22 10 46

tertsdiepraam reacted with thumbs up emoji
@sylvestre
Copy link
Collaborator

this is excellent, thanks!

LouisDISPA reacted with heart emoji

@tertsdiepraam
Copy link
Member

Looks excellent! I like the implementation with CSS variables too. Any reason to keep this as a draft?

LouisDISPA reacted with heart emoji

@LouisDISPA
Copy link
ContributorAuthor

Sorry for the late response.
I put this as a draft to see if you were interested in this.
Thanks you very much for the feedback!

I fixed up a bit the variable and also propose to capitalize the menu and titles for consistency.
I can revert the last commit if you don't like it.

Capture d’écran 2025-02-27 à 23 05 59

I tested all pages in light and dark mode, I think it's safe now.
You can merge this PR like this it !

@LouisDISPALouisDISPA marked this pull request as ready for reviewFebruary 27, 2025 22:09
@sylvestresylvestre merged commitaa24730 intouutils:mainFeb 28, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@LouisDISPA@sylvestre@tertsdiepraam
[8]ページ先頭
©2009-2025 Movatter.jp