Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

uucore: support cygwin#9535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sylvestre merged 1 commit intouutils:mainfromognevny:cygwin-support
Dec 2, 2025
Merged

Conversation

@ognevny
Copy link
Contributor

@ognevnyognevny commentedDec 1, 2025•
edited
Loading

requireslibc patch, mio v1.1.0 andnix patch. behavior is mostly matched with Linux. UNIX_PROGS are currently not supported due to missing ctor/dtor support of cygwin (and possibly a bit more issues)

fixes#5417

oech3 reacted with rocket emoji
@sylvestre
Copy link
Contributor

please format the code! thanks

@ognevny
Copy link
ContributorAuthor

please format the code! thanks

I'm in hurry a bit. done

@sylvestre
Copy link
Contributor

please format the code! thanks

I'm in hurry a bit. done

well, i am not :) so, please take your time :)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@ognevnyognevny marked this pull request as draftDecember 1, 2025 08:24
@ognevny
Copy link
ContributorAuthor

ognevny commentedDec 1, 2025•
edited
Loading

I started to test it, and it seems that signals handling is broken... needs investigation :(
edit:

==>  MINGW_ARCH: clang64  -> Building clang64.../etc/post-install/05-home-dir.post: строка 4: exec: id: не найден==> Сборка пакета mingw-w64-dust 1.2.3-1 (2025 M12 1, Mon 11:23:41)==> Проверка зависимостей для запуска...==> Проверка зависимостей для сборки.../usr/bin/makepkg: строка 1297: chmod: команда не найдена==> ОШИБКА: An unknown error has occurred. Exiting...==> Очистка.../usr/bin/makepkg-mingw: строка 112: 16910 User defined signal 1   MSYSTEM="${_mingw^^}" CHERE_INVOKING=1 bash -leo pipefail -c "/usr/bin/makepkg --config /etc/makepkg_mingw.conf \"\$@\"" bash "$@"

@oech3
Copy link
Contributor

oech3 commentedDec 1, 2025 via email

Please use LANG=C makepkg .
I started to test it, and it seems that signals handling is broken...
I think buildable is enough at a moment.

@ognevny
Copy link
ContributorAuthor

ognevny commentedDec 1, 2025•
edited
Loading

Please use LANG=C makepkg .

messages in Russian are printed by makepkg, so it doesn't matter much

edit: but yeah, chmod is missing

@ognevnyognevnyforce-pushed thecygwin-support branch 2 times, most recently from6113cda to6747b40CompareDecember 1, 2025 09:19
@ognevny
Copy link
ContributorAuthor

ctor doesn't support Cygwin so I have to leave it without UNIX_PROGS for now

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@ognevnyognevny marked this pull request as ready for reviewDecember 1, 2025 09:54
@ognevny
Copy link
ContributorAuthor

I started to test it, and it seems that signals handling is broken... needs investigation :(

for reference they're defined here:https://cygwin.com/cgit/newlib-cygwin/tree/winsup/cygwin/include/cygwin/signal.h#n425

@oech3

This comment was marked as resolved.

@oech3
Copy link
Contributor

requires mio v1.1.0

Is different PR to bumpmio possible?

@ognevny
Copy link
ContributorAuthor

requires mio v1.1.0

Is different PR to bumpmio possible?

no, these deps must update mio first

❯ cargo tree --invert -p miomio v1.0.4├── *crossterm v0.29.0*│   └── uu_more v0.4.0 (/home/ogn/forks/coreutils/src/uu/more)│       └── coreutils v0.4.0 (/home/ogn/forks/coreutils)├── *notify v8.2.0*│   └── uu_tail v0.4.0 (/home/ogn/forks/coreutils/src/uu/tail)│       └── coreutils v0.4.0 (/home/ogn/forks/coreutils)└── *signal-hook-mio v0.2.4*    └── crossterm v0.29.0

@ognevnyognevnyforce-pushed thecygwin-support branch 2 times, most recently from0406678 to31fbcbcCompareDecember 1, 2025 12:31
@codspeed-hq
Copy link

codspeed-hqbot commentedDec 1, 2025•
edited
Loading

CodSpeed Performance Report

Merging#9535 willnot alter performance

Comparingognevny:cygwin-support (fa71913) withmain (003f21a)

Summary

✅ 126 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase,click here and archive them to remove them from the performance reports.↩

requires [libcpatch](rust-lang/libc@a3bb40e), miov1.1.0 and [nix patch](nix-rust/nix#\2708). behavior is mostly matched with Linux
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

1 similar comment
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@sylvestresylvestre merged commit40db489 intouutils:mainDec 2, 2025
127 checks passed
@ognevnyognevny deleted the cygwin-support branchDecember 2, 2025 15:15
@oech3
Copy link
Contributor

oech3 commentedDec 2, 2025•
edited
Loading

https://github.com/rust-lang/libc/releases/tag/0.2.178 was released. It would be nice if you rerun dependabot for this.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sylvestresylvestresylvestre left review comments

+1 more reviewer

@oech3oech3oech3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cat: os error 3 on MSYS2 package

3 participants

@ognevny@sylvestre@oech3
[8]ページ先頭
©2009-2025 Movatter.jp