Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
publish.sh: be more prescriptive on the grep#7983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
otherwise, we are getting version.workspace first
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. An alternative would be to move theworkspace.package
section to the top ofCargo.toml
instead.
There is an unknown word in the commit message (and PR title): prescrive. Did you mean "precise"?
it meant "prescriptive" sorry! |
2f577a7
intomainUh oh!
There was an error while loading.Please reload this page.
otherwise, we are getting version.workspace first
otherwise, we are getting version.workspace first