NotificationsYou must be signed in to change notification settings
Fork1.5k
Star20.9k

uptime: refactor, move some codes to uucore#7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sylvestre merged 3 commits intouutils:mainfromBluemangoo:feature/refactor-uptime

Feb 20, 2025

Merged

uptime: refactor, move some codes to uucore#7289

sylvestre merged 3 commits intouutils:mainfromBluemangoo:feature/refactor-uptime

Feb 20, 2025

Conversation

Copy link

Contributor

Bluemangoo commentedFeb 9, 2025•
edited
Loading

Move some code from uu_uptime to uucore,to use them in uu_top.

It may duplicate#7256. When I started,#7256 was not yet open.

I also implement Windows(except load average, it seems impossible)

Copy link

ContributorAuthor

Bluemangoo commentedFeb 9, 2025

Some functions throw errors, should I create a thiserror enum? or is there a existed one i can add some entries?

Copy link

github-actionsbot commentedFeb 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Bluemangoo force-pushed thefeature/refactor-uptime branch 2 times, most recently froma4b78ae to7fd063bCompare

February 10, 2025 09:47

Copy link

github-actionsbot commentedFeb 10, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Bluemangoo force-pushed thefeature/refactor-uptime branch 3 times, most recently from2a69c60 toc704d7fCompare

February 10, 2025 13:10

Copy link

github-actionsbot commentedFeb 10, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Copy link

ContributorAuthor

Bluemangoo commentedFeb 11, 2025

I encountered a problem: How to install libsystemd-dev for the corresponding arch in cross. in cross image there are no apt source for it(only amd64 and i386).

For example, in armhf, I try to add source(in pre-build command, and then install):

dpkg --add-architecture armhf&&echo'deb [arch=armhf] http://ports.ubuntu.com/ bionic main restricteddeb [arch=armhf] http://ports.ubuntu.com/ bionic-updates main restricteddeb [arch=armhf] http://ports.ubuntu.com/ bionic universedeb [arch=armhf] http://ports.ubuntu.com/ bionic-updates universedeb [arch=armhf] http://ports.ubuntu.com/ bionic multiversedeb [arch=armhf] http://ports.ubuntu.com/ bionic-updates multiversedeb [arch=armhf] http://ports.ubuntu.com/ bionic-backports main restricted universe multiverse'>>/etc/apt/sources.list&&apt-get update

Failed for dependent conflicts :(

sylvestre force-pushed thefeature/refactor-uptime branch fromc704d7f toc6c1dc5Compare

February 12, 2025 09:16

Copy link

github-actionsbot commentedFeb 12, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/rm/rm2 is no longer failing!

uptime: refactor

2fd4f48

Bluemangoo force-pushed thefeature/refactor-uptime branch fromc6c1dc5 to585b84eCompare

February 13, 2025 09:18

uptime: move some codes to uucore

5a28db5

Bluemangoo force-pushed thefeature/refactor-uptime branch from585b84e to5a28db5Compare

February 13, 2025 09:40

Copy link

github-actionsbot commentedFeb 13, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)Congrats! The gnu test tests/misc/tee is no longer failing!

Copy link

github-actionsbot commentedFeb 13, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)