Cleanup base on IDEA Code Inspector and small refactoring#59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pesse merged 3 commits intoutPLSQL:developfromPazus:feature/cleanup

Jul 17, 2018

Merged

Cleanup base on IDEA Code Inspector and small refactoring#59

pesse merged 3 commits intoutPLSQL:developfromPazus:feature/cleanup

Jul 17, 2018

Conversation

Copy link

Member

Pazus commentedJul 14, 2018

Trivial cleanup (remove unnecessary imports, making properties final, simplified if statements etc) based on IDEA code inspector

Refactored creation of ReporterInspectors. Made them immutable, separated creation from ReporterInfo collection fill
Made TestRunnerStatement AutoClosable to be used with try-with-resource
For SQLData implementations (FileMapping, KeyValuePair) made setters private

Trivial cleanup (remove unnecessary imports, making properties final,…

5c6f000

… simplified if statements etc) based on IDEA code inspectorRefactored creation of ReporterInspectors. Made them immutable, separated creation from ReporterInfo collection fillMade TestRunnerStatement AutoClosable to be used with try-with-resourceFor SQLData implementations (FileMapping, KeyValuePair) made setters private

Pazus added the enhancement label

Jul 14, 2018

Pazus added2 commits

July 14, 2018 11:56

Added several new finals

6e34be6

added private constructors to pure utility static classesRefactored Version class to be immutable

tests imports optimized

141215a

refactored ReportInspectors: moved Map creation to interface default method, moved info storage and initialization to subclasses from abstract class.Fixed test failure due to wrong order of construction