Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Creating a list of annotations allowed to treat package as annotated#1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lwasylow wants to merge5 commits intodevelop
base:develop
Choose a base branch
Loading
fromfeature/issue_1278

Conversation

lwasylow
Copy link
Member

Resolve#1278

Root problem is the issue that package is being treated as annotate which allows it to be pushed into cache_suite table.
The solution is the do not treat object as annotated if the--% does not contain a valid annotation that is specified by framework.
e.g. ignore comments like --%parameter

This will allow for greater flexibility for documenting.

Current issues is that any comment matching annotation --% is pushed into ut cache packages which causes exclusion from coverage reports.
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 10, 2025•
edited
Loading

Unit Test Results

       1 files  ±  0         2 suites  ±0   2m 40s⏱️ -48s
1 084 tests +26  1 080✔️ +26  4💤 ±0  0❌ ±0 
1 088 runs  +26  1 080✔️ +26  8💤 ±0  0❌ ±0 

Results for commit463b84b. ± Comparison against base commite872b30.

♻️ This comment has been updated with latest results.

@lwasylowlwasylow requested a review fromjgebalApril 10, 2025 19:41
@codecovCodecov
Copy link

codecovbot commentedApr 10, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base(e872b30) to head(463b84b).

Additional details and impacted files
@@           Coverage Diff            @@##           develop    #1297   +/-   ##========================================  Coverage    94.97%   94.98%           ========================================  Files          111      111             Lines         5396     5403    +7       Branches        34       33    -1     ========================================+ Hits          5125     5132    +7  Misses         271      271
FlagCoverage Δ
11XE?
12.1EE94.47% <100.00%> (+0.04%)⬆️
18XE95.10% <100.00%> (+<0.01%)⬆️
21XE95.25% <100.00%> (+<0.01%)⬆️
23free94.99% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jgebaljgebalAwaiting requested review from jgebal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage not being reported when comment starts with --%param
1 participant
@lwasylow
[8]ページ先頭
©2009-2025 Movatter.jp