Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.1k
fix: add placeholder frontend dist for development#5493
Open
thefatcode wants to merge 3 commits intousememos:mainfrom
Open
fix: add placeholder frontend dist for development#5493thefatcode wants to merge 3 commits intousememos:mainfrom
thefatcode wants to merge 3 commits intousememos:mainfrom
Conversation
Refactored video/audio file serving to use streaming via ReadSeekerinstead of loading entire files into memory. For local storage, filesare opened directly for zero-copy streaming. For S3 and databasestorage, content is still loaded into memory as these sources don'tprovide seekable streams. This significantly reduces memory footprintwhen serving large media files.
a196c72 to71e8a06Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes#5492
This PR adds placeholder files in
server/router/frontend/dist/so that developers can rungo run cmd/memos/main.gowithout building the frontend first.Problem
When running without Docker, executing
go run cmd/memos/main.gofails because the Go embed directive (//go:embed dist/*) cannot find the requireddistdirectory.Solution
.gitkeepto track the dist directory in gitindex.htmlthat displays friendly instructions for building the frontend.gitignoreto track these placeholder files while still ignoring built assetsTesting
go run cmd/memos/main.go- server starts successfullyhttp://localhost:8081- shows placeholder page with build instructionscd web && pnpm install && pnpm releaseto build frontend