- Notifications
You must be signed in to change notification settings - Fork240
Fix: Java JAR contains native library twice#430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main-dev
Are you sure you want to change the base?
Conversation
MarkReedZ commentedJun 1, 2024
Note that a cleaner fix for this issue would probably be to not copy the dlls and load them from In the build.gradle we copy |
ashvardanian commentedJun 1, 2024
The latter sounds like a good plan. I can wait for that patch, if you want to follow up on this branch 🤗 |
MarkReedZ commentedJun 3, 2024
Proper fix and verified the jar as in the OP. |
| System.loadLibrary("usearch");// used for tests. This library in classpath only | ||
| }catch (UnsatisfiedLinkErrore) { | ||
| try { | ||
| if (System.getProperty("os.name").equals("Mac OS X")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we know what this property is equal to on Windows? We should probably link to .dll there.
This PRfixes#314 by excluding the shared/ directory.
Tested with