Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitef45a13

Browse files
authored
[fix] Readd the empty userinfo tourl.href (#226)
If the userinfo is present but empty, the parsed host is also empty, and`url.pathname` is not `'/'`, then readd the empty userinfo to `url.href`,otherwise the original invalid URL might be transformed into a valid onewith `url.pathname` as host.
1 parent88df234 commitef45a13

File tree

2 files changed

+70
-0
lines changed

2 files changed

+70
-0
lines changed

‎index.js‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,17 @@ function toString(stringify) {
539539
}elseif(url.password){
540540
result+=':'+url.password;
541541
result+='@';
542+
}elseif(
543+
url.protocol!=='file:'&&
544+
isSpecial(url.protocol)&&
545+
!url.host&&
546+
url.pathname!=='/'
547+
){
548+
//
549+
// Add back the empty userinfo, otherwise the original invalid URL
550+
// might be transformed into a valid one with `url.pathname` as host.
551+
//
552+
result+='@';
542553
}
543554

544555
result+=url.host+url.pathname;

‎test/test.js‎

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,65 @@ describe('url-parse', function () {
771771
assume(parsed.pathname).equals('/');
772772
assume(parsed.href).equals('http://user%40:pas%3As%40@www.example.com/');
773773
});
774+
775+
it('adds @ to href if auth and host are empty',function(){
776+
varparsed,i=0;
777+
varurls=[
778+
'http:@/127.0.0.1',
779+
'http::@/127.0.0.1',
780+
'http:/@/127.0.0.1',
781+
'http:/:@/127.0.0.1',
782+
'http://@/127.0.0.1',
783+
'http://:@/127.0.0.1',
784+
'http:///@/127.0.0.1',
785+
'http:///:@/127.0.0.1'
786+
];
787+
788+
for(;i<urls.length;i++){
789+
parsed=parse(urls[i]);
790+
791+
assume(parsed.protocol).equals('http:');
792+
assume(parsed.auth).equals('');
793+
assume(parsed.username).equals('');
794+
assume(parsed.password).equals('');
795+
assume(parsed.host).equals('');
796+
assume(parsed.hostname).equals('');
797+
assume(parsed.pathname).equals('/127.0.0.1');
798+
assume(parsed.origin).equals('null');
799+
assume(parsed.href).equals('http://@/127.0.0.1');
800+
assume(parsed.toString()).equals('http://@/127.0.0.1');
801+
}
802+
803+
urls=[
804+
'http:@/',
805+
'http:@',
806+
'http::@/',
807+
'http::@',
808+
'http:/@/',
809+
'http:/@',
810+
'http:/:@/',
811+
'http:/:@',
812+
'http://@/',
813+
'http://@',
814+
'http://:@/',
815+
'http://:@'
816+
];
817+
818+
for(i=0;i<urls.length;i++){
819+
parsed=parse(urls[i]);
820+
821+
assume(parsed.protocol).equals('http:');
822+
assume(parsed.auth).equals('');
823+
assume(parsed.username).equals('');
824+
assume(parsed.password).equals('');
825+
assume(parsed.host).equals('');
826+
assume(parsed.hostname).equals('');
827+
assume(parsed.pathname).equals('/');
828+
assume(parsed.origin).equals('null');
829+
assume(parsed.href).equals('http:///');
830+
assume(parsed.toString()).equals('http:///');
831+
}
832+
});
774833
});
775834

776835
it('accepts multiple ???',function(){

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp