Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork41
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/core/transform.ts Outdated
| export function shouldTransform(code: string,id: string,options?: ScriptSetupTransformOptions): boolean { | ||
| export function shouldTransform(code: string, options?: ScriptSetupTransformOptions): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do you change the signature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do you change the signature?
没看到使用这个变量。这个是后面要用到的吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, but it's not relevant to this PR. And the function is exposed, which you might consider this as a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, but it's not relevant to this PR. And the function is exposed, which you might consider this as a breaking change
I didn't take that into account. I've changed it back
Description
PR of the original author#155
Provide unit tests
Linked Issues
Additional context