unplugin/unplugin-vue-componentsPublic

NotificationsYou must be signed in to change notification settings
Fork378
Star4.2k

feat: add components prefix#850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

antfu merged 3 commits intounplugin:mainfromilyaliao:feat/prefix

Jun 29, 2025

Merged

feat: add components prefix#850

antfu merged 3 commits intounplugin:mainfromilyaliao:feat/prefix

Jun 29, 2025

Conversation

Copy link

Collaborator

ilyaliao commentedJun 25, 2025

Description

This PR is a minimal implementation of#612. Since the original PR is outdated, I’m submitting a new one.

It simply adds support for prefixing component names.

Linked Issues

resolve:#438

feat: add components prefix

eed512d

Co-authored-by: winches <wincheshe@gmail.com>

Copy link

bolt-new-by-stackblitzbot commentedJun 25, 2025

Run & review this pull request inStackBlitz Codeflow.

fix: remove.only

4751b4a

ilyaliao marked this pull request as ready for review

June 25, 2025 14:48

ilyaliao requested a review fromantfu as acode owner

June 25, 2025 14:48

ilyaliao marked this pull request as draft

June 25, 2025 14:48

feat: only add prefix for specific components

9229587

ilyaliao marked this pull request as ready for review

June 25, 2025 15:25

antfu approved these changes

Jun 29, 2025

View reviewed changes

antfu merged commit6d86696 intounplugin:main

Jun 29, 2025

6 checks passed

antfu mentioned this pull request

Jun 29, 2025

feat: support add components prefix#612

Closed

ilyaliao deleted the feat/prefix branch

July 1, 2025 04:45

This was referencedJul 12, 2025

How to add the prefix of all components in the 'src/components' directory#385

Closed

how to add prefix with src/components or dirs ?#372

Closed

Copy link

jongbonga commentedJul 12, 2025

@ilyaliao how do I make this work with primevue? I tried but the component doesn't show, seereproduction andissue

Copy link

CollaboratorAuthor

ilyaliao commentedJul 17, 2025•
edited
Loading

@ilyaliao how do I make this work with primevue? I tried but the component doesn't show, seereproduction andissue

Hi jongbonga 👋

Thanks for asking, but sorry, this PR doesn't include adding prefix inresolvers, but I think I can help you solve the problem!

Please refer to:primefaces/primevue#6875 (comment)

Copy link

craigrileyuk commentedJul 28, 2025•
edited
Loading

This should probably be added to the README documentation now it's merged.

Copy link

CollaboratorAuthor

ilyaliao commentedJul 28, 2025

This should probably be added to the README documentation now it's merged.

Good idea! Would you like to open a PR?

Copy link

jhoefker commentedJul 31, 2025•
edited
Loading

Hey guys, thanks for adding support for prefix. Unfortunately, I face an issue while importing the components.

My setup:
vite.config.js

Components({prefix: 'Pre'})

... the components.d.ts is generated correctly with:

...PreBadgeCircle: typeof import('./src/components/design-system/badge-circle/badge-circle.vue')['default']...

However I can't import the component with<pre-badge-circle> in my components. I get this error:

Failed to resolve component: pre-badge-circleIf this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.

Interesting is that using<badge-circle> still works.

Have I forgot something in the config?

Copy link

CollaboratorAuthor

ilyaliao commentedJul 31, 2025

Hey guys, thanks for adding support for prefix. Unfortunately, I face an issue while importing the components.
My setup: vite.config.js
Components({prefix: 'Pre'})
... the components.d.ts is generated correctly with:
...PreBadgeCircle: typeof import('./src/components/design-system/badge-circle/badge-circle.vue')['default']...
However I can't import the component with<pre-badge-circle> in my components. I get this error:
Failed to resolve component: pre-badge-circleIf this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
Interesting is that using<badge-circle> still works.
Have I forgot something in the config?

This looks like a bug, I will fix it.