Commitf5acc6a

committed

fix(diagram): correct builder update call placement#438

Move builder update logic outside conditional to ensure updates run consistently.

1 parentc9bda9d commitf5acc6aCopy full SHA for f5acc6a

File tree

-8

lines changed

-8

lines changed

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,13 +57,13 @@ class GraphvizDiagramPanel(private val fileEditor: DiagramPreviewFileEditor) : D`
`57`	`57`	`actionToolbar.component.setBorder(JBUI.Borders.customLine(JBColor.border(),0,0,1,0))`
`58`	`58`
`59`	`59`	`chartPanel.add(actionToolbar.component,BorderLayout.NORTH)`
`60`		`-`
`61`		`- builder!!.queryUpdate()`
`62`		`- .withDataReload()`
`63`		`- .withPresentationUpdate()`
`64`		`- .withRelayout()`
`65`		`- .runAsync()`
`66`	`60`	`}`
	`61`	`+`
	`62`	`+ builder!!.queryUpdate()`
	`63`	`+ .withDataReload()`
	`64`	`+ .withPresentationUpdate()`
	`65`	`+ .withRelayout()`
	`66`	`+ .runAsync()`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`privatefuncreateSimpleGraphView(builder:DiagramBuilder):JComponent {`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,6 @@ class MermaidPreviewFileEditor(private val project: Project, private val file: V`
`134`	`134`	`mergingUpdateQueue.queue(object:Update("update") {`
`135`	`135`	`overridefunrun() {`
`136`	`136`	`if (isDisposed)return`
`137`		`-`
`138`	`137`	`swingAlarm.addRequest({`
`139`	`138`	`if (isDisposed)return@addRequest`
`140`	`139`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ import com.intellij.openapi.fileEditor.TextEditorWithPreviewProvider`
`9`	`9`	`* Similar to GraphvizSplitEditorProvider but for Mermaid diagrams`
`10`	`10`	`*/`
`11`	`11`	`classMermaidSplitEditorProvider :TextEditorWithPreviewProvider(MermaidPreviewFileEditorProvider()) {`
`12`		`-`
`13`	`12`	`overridefuncreateSplitEditor(firstEditor:TextEditor,secondEditor:FileEditor):FileEditor {`
`14`	`13`	`returnMermaidEditorWithPreview(firstEditor, secondEditorasMermaidPreviewFileEditor)`
`15`	`14`	`}`

Comments

(0)