Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: initial support for custom deployments and routes#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ErikBjare merged 4 commits intouniswap-python:masterfromErikBjare:dev/honeyswap
May 4, 2021

Conversation

ErikBjare
Copy link
Member

Very WIP.

@ErikBjareErikBjare mentioned this pull requestJan 20, 2021
@ErikBjare
Copy link
MemberAuthor

ErikBjare commentedJan 20, 2021•
edited
Loading

As I mentioned in#62, it might be better to add the ability to override the router and factory contract addresses from the constructor parameters (since it generalizes support across all Uniswap clones).

@ErikBjareErikBjare changed the titlefeat: initial support for Honeyswap (on xDai)feat: initial support for Honeyswap (on xDai) and specific routesJan 20, 2021
@ErikBjareErikBjare mentioned this pull requestFeb 22, 2021
@ErikBjareErikBjare mentioned this pull requestApr 27, 2021
@ErikBjareErikBjare changed the titlefeat: initial support for Honeyswap (on xDai) and specific routesfeat: initial support for custom deploymentsMay 4, 2021
@ErikBjareErikBjare marked this pull request as ready for reviewMay 4, 2021 12:13
@ErikBjare
Copy link
MemberAuthor

Tests pass locally (after fixing what I thought was the cause of#88). Not sure why they don't work in CI.

Maybe because the token is secret and not available in PRs?

Works now anyway, merging.

@ErikBjareErikBjare merged commit00c77d6 intouniswap-python:masterMay 4, 2021
@ErikBjareErikBjare deleted the dev/honeyswap branchMay 4, 2021 12:13
This was referencedMay 4, 2021
@ErikBjareErikBjare changed the titlefeat: initial support for custom deploymentsfeat: initial support for custom deployments and routesMay 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ErikBjare
[8]ページ先頭
©2009-2025 Movatter.jp