- Notifications
You must be signed in to change notification settings - Fork386
fix: Make fee a required argument with Uniswap V3#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Additionally, I updated the changelog and the project's version and added tests for new functionality. Feel free to let me know if any changes are desirable! |
Beautiful PR! Thanks a lot for this. Will give it a final review and merge tomorrow :) |
| @@ -474,13 +476,6 @@ def test_make_trade( | |||
| # ("ETH", "UNI", int(0.000001 * ONE_ETH), ZERO_ADDRESS), | |||
| # ("UNI", "ETH", int(0.000001 * ONE_ETH), ZERO_ADDRESS), | |||
| # ("DAI", "UNI", int(0.000001 * ONE_ETH), ZERO_ADDRESS), | |||
| ( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I fixed the failing tests, though I ask you to take a look at the deleted test line. It was failing becauseInsufficientBalance wasn't raised during the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Strange, I will add this back in a new PR and sort it out later.
codecovbot commentedDec 6, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #358 +/- ##==========================================+ Coverage 83.84% 84.20% +0.36%========================================== Files 10 11 +1 Lines 1052 1057 +5 ==========================================+ Hits 882 890 +8+ Misses 170 167 -3 ☔ View full report in Codecov by Sentry. |
The Arbitrum test fails due to "rate limit exceeded", which we will ignore, so all is good! Thanks for your contribution! ❤️ |
Solves#355
Partially solves#356
What's new?
uniswap.fee.FeeTierenum added with all available tiers combinedInvalidFeeTierraised when Uniswap v3 is used without explicitly providing a fee argumentInvalidFeeTierraised when the fee is invalid (not a number, not a FeeTier's member)