- Notifications
You must be signed in to change notification settings - Fork386
feat: price impact excludes fees#325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@ErikBjare just wanted to bring this PR to your attention again |
ErikBjare left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Just remove the unused function and format with black.
uniswap/util.py Outdated
| def fee_to_fraction(fee:int): | ||
| return fee / 1000000 | ||
| def fraction_to_fee(fraction:float): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Unused
Hey@ErikBjare removed the function and formatted with black 👍 |
@ErikBjare just wanted to bring this PR to your attention again |
Very nice, thanks for the ping! |
And thanks for contributing! ❤️ |
Glad to have helped! 🙌 |
Based on discussion in:#310