Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: update web3py to v6, apply no-implicit-optional, misc fixes#320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ErikBjare merged 13 commits intomasterfromdev/misc-fixes2
Mar 30, 2023

Conversation

ErikBjare
Copy link
Member

@ErikBjareErikBjare commentedFeb 24, 2023•
edited
Loading

Fixes#322

@codecov
Copy link

codecovbot commentedFeb 24, 2023•
edited
Loading

Codecov Report

Patch coverage:64.28% and project coverage change:-24.29⚠️

Comparison is base(da8c7dd) 84.35% compared to head(ece7f1e) 60.07%.

❗ Current headece7f1e differs from pull request most recent head1956fec. Consider uploading reports for the commit1956fec to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@##           master     #320       +/-   ##===========================================- Coverage   84.35%   60.07%   -24.29%===========================================  Files          10       10                 Lines        1042     1042               ===========================================- Hits          879      626      -253- Misses        163      416      +253
Impacted FilesCoverage Δ
uniswap/cli.py92.95% <0.00%> (ø)
uniswap/tokens.py64.28% <ø> (-21.43%)⬇️
uniswap/uniswap.py53.34% <57.14%> (-28.97%)⬇️
uniswap/util.py64.86% <100.00%> (-21.63%)⬇️

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment?Let us know in this issue.

@ErikBjare
Copy link
MemberAuthor

ErikBjare commentedMar 29, 2023•
edited
Loading

I'm stumped, I keep gettingRevert reason: Not WETH9 for some reason :<

Also, why is CI not running?

@ErikBjareErikBjare removed the request for review fromliquid-8March 30, 2023 13:10
@ErikBjare
Copy link
MemberAuthor

Alright, finally done now.

Shipping:shipit:

@ErikBjareErikBjare changed the titleMisc fixes: update deps, apply no-implicit-optional, updated web3py namesfix: update web3py to v6, apply no-implicit-optional, misc fixesMar 30, 2023
@liquid-8
Copy link
Member

I couldn't manage to review it in time; sorry for that. I was going to take a look today. However, I'm glad it is fine now.

ErikBjare reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error importing Uniswap with the latest version of web3.py
2 participants
@ErikBjare@liquid-8
[8]ページ先頭
©2009-2025 Movatter.jp