Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix:fee argument not respected inmake_trade_output#306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ErikBjare merged 1 commit intouniswap-python:masterfromjz448:master
Dec 23, 2022

Conversation

jz448
Copy link
Contributor

Bug: Themake_trade_output function accepts thefee parameter but doesn't pass it to theself._get_eth_token_output_price function.

This PR fixes this bug.

@codecov
Copy link

codecovbot commentedDec 18, 2022•
edited
Loading

Codecov Report

Base:84.06% // Head:83.87% // Decreases project coverage by-0.19%⚠️

Coverage data is based on head(50030ce) compared to base(3554749).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #306      +/-   ##==========================================- Coverage   84.06%   83.87%   -0.20%==========================================  Files          10       10                Lines        1042     1042              ==========================================- Hits          876      874       -2- Misses        166      168       +2
Impacted FilesCoverage Δ
uniswap/uniswap.py82.05% <100.00%> (-0.25%)⬇️

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

@ErikBjareErikBjare changed the titlefix: thefee variable is not used in themake_trade_output functionfix:fee argument not respected inmake_trade_outputDec 23, 2022
@ErikBjareErikBjare merged commit1554b30 intouniswap-python:masterDec 23, 2022
@ErikBjare
Copy link
Member

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jz448@ErikBjare
[8]ページ先頭
©2009-2025 Movatter.jp