Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: add test for ValueError in make_trade_output#301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ytoast
Copy link
Contributor

@ytoastytoast commentedDec 12, 2022•
edited
Loading

I will like to work on issue#265

Tested locally and test runs well. I also pushed a PR on my own fork to test.
In this PR I added a simple test to slightly improve code coverage and also to test the workflow

@codecov
Copy link

codecovbot commentedDec 12, 2022•
edited
Loading

Codecov Report

Base:84.06% // Head:84.16% // Increases project coverage by+0.09% 🎉

Coverage data is based on head(f902e31) compared to base(3554749).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #301      +/-   ##==========================================+ Coverage   84.06%   84.16%   +0.09%==========================================  Files          10       10                Lines        1042     1042              ==========================================+ Hits          876      877       +1+ Misses        166      165       -1
Impacted FilesCoverage Δ
uniswap/uniswap.py82.42% <0.00%> (+0.12%)⬆️

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

@ErikBjareErikBjare changed the titletest: Added test for ValueError in make_trade_outputtest: add test for ValueError in make_trade_outputDec 23, 2022
@ErikBjareErikBjare merged commit3acc728 intouniswap-python:masterDec 23, 2022
@ErikBjare
Copy link
Member

Thanks @brndtoast! ❤️

ytoast reacted with heart emoji

@ytoastytoast deleted the test/uniswap-improve-eth-swap branchJanuary 12, 2023 10:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ytoast@ErikBjare
[8]ページ先頭
©2009-2025 Movatter.jp