- Notifications
You must be signed in to change notification settings - Fork386
Enable caching to reduce RPC calls#276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
enable caching, will reduce RPC calls for method chainID
ErikBjare commentedSep 28, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The Perhaps look into some of the more sophisticated caching methods? Or we might just want to inform users how to do this themselves in the docs by constructing a custom web3 with a caching layer of choice. Edit: It seems you can provide a |
good call@ErikBjare , adding changes |
- custom eth caching middleware creation- custom SIMPLE_CACHE_RPC_WHITELIST- flag to enable/disable caching for class Uniswap
added changes, looking for any commentary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Going to let CI run now and will merge if it works :)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedOct 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportBase:84.56% // Head:84.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@## master #276 +/- ##==========================================- Coverage 84.56% 84.13% -0.43%========================================== Files 10 10 Lines 1030 1040 +10 ==========================================+ Hits 871 875 +4- Misses 159 165 +6
Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here. ☔ View full report at Codecov. |
Thanks for this@PawlowskiAdrian :) |
enable caching, will reduce RPC calls for method chainID