Mar 5, 2022 · Mar 5, 2022 · Mar 7, 2022 · Mar 7, 2022 · Jul 13, 2022 · Jul 13, 2022
diff --git a/uniswap/uniswap.py b/uniswap/uniswap.py
                logger.warning(f"No route specified, assuming route: {route}")

        if self.version == 2:
            # BL: This is where route param gets called
            price: int = self.router.functions.getAmountsOut(qty, route).call()[-1]
        elif self.version == 3:
            if route:
        fee: int = None,
        slippage: float = None,
        fee_on_transfer: bool = False,
        route: Optional[List[AddressLike]] = None,
    ) -> HexBytes:
        """Make a trade by defining the qty of the input token."""
        if fee is None:
                fee,
                slippage,
                fee_on_transfer,
                route=route
            )

    @check_approval
        fee: int,
        slippage: float,
        fee_on_transfer: bool = False,
        route: Optional[List[AddressLike]] = None,
    ) -> HexBytes:
        """Convert tokens to tokens given an input amount."""
        # Balance check
            min_tokens_bought = int(
                (1 - slippage)
                * self._get_token_token_input_price(
                    input_token, output_token, qty, fee=fee
                    input_token, output_token, qty, fee=fee, route=route
                )
            )
            if fee_on_transfer:
Original file line number	Diff line number	Diff line change
Expand Up		@@ -284,6 +284,7 @@ def _get_token_token_input_price(
		logger.warning(f"No route specified, assuming route: {route}")

		if self.version == 2:
		# BL: This is where route param gets called
		price: int = self.router.functions.getAmountsOut(qty, route).call()[-1]
		elif self.version == 3:
		if route:
Expand DownExpand Up		@@ -401,6 +402,7 @@ def make_trade(
		fee: int = None,
		slippage: float = None,
		fee_on_transfer: bool = False,
		route: Optional[List[AddressLike]] = None,
Copy link Member ErikBjareJul 13, 2022• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Might lead to unexpected behavior if`route` is specified but not respected (such as in the eth_to_token and token_to_eth cases).
		) -> HexBytes:
		"""Make a trade by defining the qty of the input token."""
		if fee is None:
Expand DownExpand Up		@@ -431,6 +433,7 @@ def make_trade(
		fee,
		slippage,
		fee_on_transfer,
		route=route
		)

		@check_approval
Expand DownExpand Up		@@ -652,6 +655,7 @@ def _token_to_token_swap_input(
		fee: int,
		slippage: float,
		fee_on_transfer: bool = False,
		route: Optional[List[AddressLike]] = None,
Copy link Member ErikBjareJul 13, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Same concern as above, needs to be respected in all cases, or raise an exception if it can't.
		) -> HexBytes:
		"""Convert tokens to tokens given an input amount."""
		# Balance check
Expand DownExpand Up		@@ -690,7 +694,7 @@ def _token_to_token_swap_input(
		min_tokens_bought = int(
		(1 - slippage)
		* self._get_token_token_input_price(
		input_token, output_token, qty, fee=fee
		input_token, output_token, qty, fee=fee, route=route
		)
		)
		if fee_on_transfer:
Expand Down