- Notifications
You must be signed in to change notification settings - Fork386
feat: make_trade add optional route param#239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -401,6 +402,7 @@ def make_trade( | |||
| fee: int = None, | |||
| slippage: float = None, | |||
| fee_on_transfer: bool = False, | |||
| route: Optional[List[AddressLike]] = None, | |||
ErikBjareJul 13, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might lead to unexpected behavior ifroute is specified but not respected (such as in the eth_to_token and token_to_eth cases).
| @@ -652,6 +655,7 @@ def _token_to_token_swap_input( | |||
| fee: int, | |||
| slippage: float, | |||
| fee_on_transfer: bool = False, | |||
| route: Optional[List[AddressLike]] = None, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same concern as above, needs to be respected in all cases, or raise an exception if it can't.
No description provided.