- Notifications
You must be signed in to change notification settings - Fork386
feat: added Optimism and Arbitrum support (updated constants.py)#186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Also 421611 => "arbitrum_testnet" |
BTW, I'm using uniswap-python on arbitrum, and I had to monkey patch |
I've checked some uni swaps on arbitrum and it turns out txn requires gas spendings ~1m but |
Yes, I can testify: 1,078,834 |
ErikBjare commentedOct 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Perhaps the gas parameter could be removed entirely from
|
Merging this for now, we'll deal with any issues in future PRs. |
Uniswap3 suggest doing 1.2 * estimateGas. I can make a PR if you want. |
@romanbsd That would be appreciated :) |
Closes#185
Closes#183
Closes#176