Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: add additional test instructions to README#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ErikBjare merged 2 commits intouniswap-python:masterfromericjang:patch-1
May 31, 2021

Conversation

ericjang
Copy link
Contributor

I'm new to poetry workflows, and noticed that the test suite assumes two environment variables are set.

By the way, is there any particular reason why MAINNET_PROVIDER and PROVIDER can't be consolidated into a single variable?

I'm new to poetry workflows, and noticed that the test suite assumes two environment variables are set. By the way, is there any particular reason why MAINNET_PROVIDER and PROVIDER can't be consolidated into a single variable?
@ErikBjare
Copy link
Member

Thanks for the contributions and the shoutout on Twitter!

By the way, is there any particular reason why MAINNET_PROVIDER and PROVIDER can't be consolidated into a single variable?

There used to be, but there isn't really anymore. I'll push changes to fix this in a couple min.

ericjang reacted with thumbs up emoji

@ErikBjareErikBjare changed the titleAdd additional test instructions to READMEdocs: add additional test instructions to READMEMay 31, 2021
@ErikBjareErikBjare merged commit6af0f28 intouniswap-python:masterMay 31, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ErikBjareErikBjareErikBjare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ericjang@ErikBjare
[8]ページ先頭
©2009-2025 Movatter.jp