- Notifications
You must be signed in to change notification settings - Fork386
feat: initial work on v3#106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
# FIXME: How to calculate this properly? | ||
# - https://docs.uniswap.org/reference/libraries/SqrtPriceMath | ||
# - https://github.com/Uniswap/uniswap-v3-sdk/blob/main/src/swapRouter.ts | ||
sqrtPriceLimitX96 = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is new, haven't looked into it...
Also, uniswap-v3-sdk is a great reference.
Uh oh!
There was an error while loading.Please reload this page.
ErikBjare commentedMay 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Been investigating some weirdness in the Quoter:
https://docs.uniswap.org/reference/periphery/interfaces/IQuoter Found@shanefontaine's posthttps://medium.com/authereum/getting-ethereum-transaction-revert-reasons-the-easy-way-24203a4d1844, but would need the equivalent for Python lol |
ErikBjare commentedMay 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All v3 tests are now passing for me locally. Not sure why CI is failing... However, two tests for v2 are failing, as well as one for v1. Probably going to merge this for now, we can continue the work in a follow-up PR. |
I just remembered that CI is likely failing due not having access to secrets in PRs (maybe it's just because the branch is on my own fork?). After some debugging, I got the tests to print this:
|
Tried setting the secret in my own fork, but no success. Gonna merge this and hope for the best... |
No description provided.