Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: initial work on v3#106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ErikBjare merged 19 commits intouniswap-python:masterfromErikBjare:dev/v3-mvp
May 17, 2021
Merged

Conversation

ErikBjare
Copy link
Member

No description provided.

Comment on lines +525 to +528
# FIXME: How to calculate this properly?
# - https://docs.uniswap.org/reference/libraries/SqrtPriceMath
# - https://github.com/Uniswap/uniswap-v3-sdk/blob/main/src/swapRouter.ts
sqrtPriceLimitX96 = 0
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is new, haven't looked into it...

Also, uniswap-v3-sdk is a great reference.

@ErikBjareErikBjare mentioned this pull requestMay 15, 2021
8 tasks
@ErikBjare
Copy link
MemberAuthor

ErikBjare commentedMay 17, 2021
edited
Loading

Been investigating some weirdness in the Quoter:

These functions are not marked view because they rely on calling non-view functions and reverting to compute the result. They are also not gas efficient and should not be called on-chain.

https://docs.uniswap.org/reference/periphery/interfaces/IQuoter

Found@shanefontaine's posthttps://medium.com/authereum/getting-ethereum-transaction-revert-reasons-the-easy-way-24203a4d1844, but would need the equivalent for Python lol

@ErikBjare
Copy link
MemberAuthor

ErikBjare commentedMay 17, 2021
edited
Loading

All v3 tests are now passing for me locally. Not sure why CI is failing...

However, two tests for v2 are failing, as well as one for v1.

Probably going to merge this for now, we can continue the work in a follow-up PR.

@ErikBjare
Copy link
MemberAuthor

I just remembered that CI is likely failing due not having access to secrets in PRs (maybe it's just because the branch is on my own fork?).

After some debugging, I got the tests to print this:

<Result MissingSchema("Invalid URL '': No schema supplied. Perhaps you meant http://?")>

@ErikBjare
Copy link
MemberAuthor

Tried setting the secret in my own fork, but no success.

Gonna merge this and hope for the best...

@ErikBjareErikBjare merged commitd93e86f intouniswap-python:masterMay 17, 2021
@ErikBjareErikBjare deleted the dev/v3-mvp branchMay 17, 2021 13:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ErikBjare

[8]ページ先頭

©2009-2025 Movatter.jp